Skip to content

Commit 80c25f3

Browse files
authored
build: ensure npm is used for watch task (aws#6871)
## Problem ``` * Executing task in folder amazonq: yarn run watch zsh:1: command not found: yarn * The terminal process "/opt/homebrew/bin/zsh '-l', '-c', 'yarn run watch'" failed to launch (exit code: 127). * Terminal will be reused by tasks, press any key to close it. ``` Seems to be a vscode issue. - microsoft/vscode#181006 - microsoft/vscode#159465 Given that we already have `npm.packageManager` set to `npm` in this repo, I'm not sure why it keeps trying to use `yarn`. ## Solution Run the watch task as a shell script --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 6b9bce3 commit 80c25f3

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

packages/amazonq/.vscode/tasks.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55
"tasks": [
66
{
77
"label": "watch",
8-
"type": "npm",
9-
"script": "watch",
8+
"type": "shell",
9+
"command": "npm",
10+
"args": ["run", "watch"],
1011
"problemMatcher": "$tsc-watch",
1112
"isBackground": true,
1213
"group": {

packages/core/.vscode/tasks.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,9 @@
1010
},
1111
{
1212
"label": "watch",
13-
"type": "npm",
14-
"script": "watch",
13+
"type": "shell",
14+
"command": "npm",
15+
"args": ["run", "watch"],
1516
"problemMatcher": "$tsc-watch",
1617
"isBackground": true
1718
},

packages/toolkit/.vscode/tasks.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@
1414
},
1515
{
1616
"label": "watch",
17-
"type": "npm",
18-
"script": "watch",
17+
"type": "shell",
18+
"command": "npm",
19+
"args": ["run", "watch"],
1920
"problemMatcher": "$tsc-watch",
2021
"isBackground": true,
2122
"group": {

0 commit comments

Comments
 (0)