Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix trailing data exception #62

Open
DamKast opened this issue Dec 10, 2024 · 0 comments
Open

fix trailing data exception #62

DamKast opened this issue Dec 10, 2024 · 0 comments

Comments

@DamKast
Copy link
Collaborator

DamKast commented Dec 10, 2024

When there is trailing data in a frame an ValueError is raised. But we should only log a warning.

types/commands.py:from_frame

                else:
                    # Otherwise, let the exception happen
                    raise
        if data:
            raise ValueError(
                f"Frame {frame} contains trailing data after parsing: {data}"
            )

        return cls(**params)
@DamKast DamKast changed the title fix trailing data raise fix trailing data exception Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant