Merge pull request #179 from chaosi-zju/staticcheck2

format code about exported function should have comment

Author: karmada-bot

cmd/api/app/router/middleware.go

@@ -27,6 +27,7 @@ import (
 	"github.com/karmada-io/dashboard/pkg/client"
 )
 
+// EnsureMemberClusterMiddleware ensures that the member cluster exists.
 func EnsureMemberClusterMiddleware() gin.HandlerFunc {
 	return func(c *gin.Context) {
 		karmadaClient := client.InClusterKarmadaClient()

cmd/api/app/router/setup.go

@@ -47,14 +47,17 @@ func init() {
 	})
 }
 
+// V1 returns the router group for /api/v1 which for resources in control plane endpoints.
 func V1() *gin.RouterGroup {
 	return v1
 }
 
+// Router returns the main Gin engine instance.
 func Router() *gin.Engine {
 	return router
 }
 
+// MemberV1 returns the router group for /api/v1/member/:clustername which for resources in specific member cluster.
 func MemberV1() *gin.RouterGroup {
 	return member
 }

cmd/api/app/routes/cluster/accesscluster.go

@@ -42,9 +42,11 @@ const (
 	// KarmadaAgentServiceAccountName is the name of karmada-agent serviceaccount
 	KarmadaAgentServiceAccountName = "karmada-agent-sa"
 	// KarmadaAgentName is the name of karmada-agent
-	KarmadaAgentName  = "karmada-agent"
+	KarmadaAgentName = "karmada-agent"
+	// KarmadaAgentImage is the image of karmada-agent
 	KarmadaAgentImage = "karmada/karmada-agent:latest"
-	ClusterNamespace  = "karmada-cluster"
+	// ClusterNamespace is the namespace of cluster
+	ClusterNamespace = "karmada-cluster"
 )
 
 var (
@@ -53,7 +55,7 @@ var (
 	timeout              = 5 * time.Minute
 )
 
-type PullModeOption struct {
+type pullModeOption struct {
 	karmadaClient          karmadaclientset.Interface
 	karmadaAgentCfg        *clientcmdapi.Config
 	memberClusterNamespace string
@@ -63,7 +65,7 @@ type PullModeOption struct {
 }
 
 // createSecretAndRBACInMemberCluster create required secrets and rbac in member cluster
-func (o PullModeOption) createSecretAndRBACInMemberCluster() error {
+func (o pullModeOption) createSecretAndRBACInMemberCluster() error {
 	configBytes, err := clientcmd.Write(*o.karmadaAgentCfg)
 	if err != nil {
 		return fmt.Errorf("failure while serializing karmada-agent kubeConfig. %w", err)
@@ -149,7 +151,7 @@ func (o PullModeOption) createSecretAndRBACInMemberCluster() error {
 }
 
 // makeKarmadaAgentDeployment generate karmada-agent Deployment
-func (o PullModeOption) makeKarmadaAgentDeployment() *appsv1.Deployment {
+func (o pullModeOption) makeKarmadaAgentDeployment() *appsv1.Deployment {
 	karmadaAgent := &appsv1.Deployment{
 		TypeMeta: metav1.TypeMeta{
 			APIVersion: "apps/v1",
@@ -237,7 +239,7 @@ func (o PullModeOption) makeKarmadaAgentDeployment() *appsv1.Deployment {
 	return karmadaAgent
 }
 
-func AccessClusterInPullMode(opts *PullModeOption) error {
+func accessClusterInPullMode(opts *pullModeOption) error {
 	_, exist, err := karmadautil.GetClusterWithKarmadaClient(opts.karmadaClient, opts.memberClusterName)
 	if err != nil {
 		return err
@@ -269,14 +271,14 @@ func AccessClusterInPullMode(opts *PullModeOption) error {
 	return nil
 }
 
-type PushModeOption struct {
+type pushModeOption struct {
 	karmadaClient           karmadaclientset.Interface
 	clusterName             string
 	karmadaRestConfig       *rest.Config
 	memberClusterRestConfig *rest.Config
 }
 
-func AccessClusterInPushMode(opts *PushModeOption) error {
+func accessClusterInPushMode(opts *pushModeOption) error {
 	registerOption := karmadautil.ClusterRegisterOption{
 		ClusterNamespace:   ClusterNamespace,
 		ClusterName:        opts.clusterName,

cmd/api/app/routes/cluster/handler.go

@@ -89,19 +89,19 @@ func handlePostCluster(c *gin.Context) {
 			common.Fail(c, err)
 			return
 		}
-		opts := &PullModeOption{
+		opts := &pullModeOption{
 			karmadaClient:          karmadaClient,
 			karmadaAgentCfg:        apiConfig,
 			memberClusterNamespace: clusterRequest.MemberClusterNamespace,
 			memberClusterClient:    memberClusterClient,
 			memberClusterName:      clusterRequest.MemberClusterName,
 			memberClusterEndpoint:  clusterRequest.MemberClusterEndpoint,
 		}
-		if err = AccessClusterInPullMode(opts); err != nil {
-			klog.ErrorS(err, "AccessClusterInPullMode failed")
+		if err = accessClusterInPullMode(opts); err != nil {
+			klog.ErrorS(err, "accessClusterInPullMode failed")
 			common.Fail(c, err)
 		} else {
-			klog.Infof("AccessClusterInPullMode success")
+			klog.Infof("accessClusterInPullMode success")
 			common.Success(c, "ok")
 		}
 	} else if clusterRequest.SyncMode == v1alpha1.Push {
@@ -117,18 +117,18 @@ func handlePostCluster(c *gin.Context) {
 			common.Fail(c, err)
 			return
 		}
-		opts := &PushModeOption{
+		opts := &pushModeOption{
 			karmadaClient:           karmadaClient,
 			clusterName:             clusterRequest.MemberClusterName,
 			karmadaRestConfig:       restConfig,
 			memberClusterRestConfig: memberClusterRestConfig,
 		}
-		if err := AccessClusterInPushMode(opts); err != nil {
-			klog.ErrorS(err, "AccessClusterInPushMode failed")
+		if err := accessClusterInPushMode(opts); err != nil {
+			klog.ErrorS(err, "accessClusterInPushMode failed")
 			common.Fail(c, err)
 			return
 		}
-		klog.Infof("AccessClusterInPushMode success")
+		klog.Infof("accessClusterInPushMode success")
 		common.Success(c, "ok")
 	} else {
 		klog.Errorf("Unknown sync mode %s", clusterRequest.SyncMode)

cmd/api/app/routes/config/handler.go

@@ -27,11 +27,13 @@ import (
 	"github.com/karmada-io/dashboard/pkg/config"
 )
 
+// GetDashboardConfig handles the request to retrieve the dashboard configuration.
 func GetDashboardConfig(c *gin.Context) {
 	dashboardConfig := config.GetDashboardConfig()
 	common.Success(c, dashboardConfig)
 }
 
+// SetDashboardConfig handles the request to update the dashboard configuration.
 func SetDashboardConfig(c *gin.Context) {
 	setDashboardConfigRequest := new(v1.SetDashboardConfigRequest)
 	if err := c.ShouldBind(setDashboardConfigRequest); err != nil {

cmd/api/app/routes/overview/misc.go

@@ -42,6 +42,7 @@ const (
 	app       = "karmada-controller-manager"
 )
 
+// GetControllerManagerVersionInfo returns the version info of karmada-controller-manager.
 func GetControllerManagerVersionInfo() (*version.Info, error) {
 	kubeClient := client.InClusterClient()
 	restConfig, _, err := client.GetKubeConfig()
@@ -92,6 +93,7 @@ func GetControllerManagerVersionInfo() (*version.Info, error) {
 	return parseVersion, nil
 }
 
+// ParseVersion parses the version string to version.Info.
 func ParseVersion(versionStr string) *version.Info {
 	versionInfo := &version.Info{}
 	leftBraceIdx := strings.IndexByte(versionStr, '{')
@@ -129,6 +131,7 @@ func ParseVersion(versionStr string) *version.Info {
 	return versionInfo
 }
 
+// GetControllerManagerInfo returns the version info of karmada-controller-manager.
 func GetControllerManagerInfo() (*v1.KarmadaInfo, error) {
 	versionInfo, err := GetControllerManagerVersionInfo()
 	if err != nil {
@@ -155,6 +158,7 @@ func GetControllerManagerInfo() (*v1.KarmadaInfo, error) {
 	return karmadaInfo, nil
 }
 
+// GetMemberClusterInfo returns the status of member clusters.
 func GetMemberClusterInfo(ds *dataselect.DataSelectQuery) (*v1.MemberClusterStatus, error) {
 	karmadaClient := client.InClusterKarmadaClient()
 	result, err := cluster.GetClusterList(karmadaClient, ds)
@@ -187,6 +191,7 @@ func GetMemberClusterInfo(ds *dataselect.DataSelectQuery) (*v1.MemberClusterStat
 	return memberClusterStatus, nil
 }
 
+// GetClusterResourceStatus returns the status of cluster resources.
 func GetClusterResourceStatus() (*v1.ClusterResourceStatus, error) {
 	clusterResourceStatus := &v1.ClusterResourceStatus{}
 	ctx := context.TODO()

cmd/api/app/types/api/v1/auth.go

@@ -16,19 +16,23 @@ limitations under the License.
 
 package v1
 
+// LoginRequest is the request for login.
 type LoginRequest struct {
 	Token string `json:"token"`
 }
 
+// LoginResponse is the response for login.
 type LoginResponse struct {
 	Token string `json:"token"`
 }
 
+// User is the user info.
 type User struct {
 	Name          string `json:"name,omitempty"`
 	Authenticated bool   `json:"authenticated"`
 }
 
+// ServiceAccount is the service account info.
 type ServiceAccount struct {
 	Name string `json:"name"`
 	UID  string `json:"uid"`

cmd/api/app/types/api/v1/cluster.go

@@ -21,6 +21,7 @@ import (
 	corev1 "k8s.io/api/core/v1"
 )
 
+// PostClusterRequest is the request body for creating a cluster.
 type PostClusterRequest struct {
 	MemberClusterKubeConfig string                   `json:"memberClusterKubeconfig" binding:"required"`
 	SyncMode                v1alpha1.ClusterSyncMode `json:"syncMode" binding:"required"`
@@ -32,26 +33,37 @@ type PostClusterRequest struct {
 	ClusterZones            []string                 `json:"clusterZones"`
 }
 
+// PostClusterResponse is the response body for creating a cluster.
 type PostClusterResponse struct {
 }
 
+// LabelRequest is the request body for labeling a cluster.
 type LableRequest struct {
 	Key   string `json:"key"`
 	Value string `json:"value"`
 }
+
+// TaintRequest is the request body for tainting a cluster.
 type TaintRequest struct {
 	Effect corev1.TaintEffect `json:"effect"`
 	Key    string             `json:"key"`
 	Value  string             `json:"value"`
 }
+
+// PutClusterRequest is the request body for updating a cluster.
 type PutClusterRequest struct {
 	Labels *[]LableRequest `json:"labels"`
 	Taints *[]TaintRequest `json:"taints"`
 }
+
+// PutClusterResponse is the response body for updating a cluster.
 type PutClusterResponse struct{}
 
+// DeleteClusterRequest is the request body for deleting a cluster.
 type DeleteClusterRequest struct {
 	MemberClusterName string `uri:"name" binding:"required"`
 }
+
+// DeleteClusterResponse is the response body for deleting a cluster.
 type DeleteClusterResponse struct {
 }

cmd/api/app/types/api/v1/deployment.go

@@ -16,9 +16,12 @@ limitations under the License.
 
 package v1
 
+// CreateDeploymentRequest defines the request structure for creating a deployment.
 type CreateDeploymentRequest struct {
 	Namespace string `json:"namespace"`
 	Name      string `json:"name"`
 	Content   string `json:"content"`
 }
+
+// CreateDeploymentResponse defines the response structure for creating a deployment.
 type CreateDeploymentResponse struct{}

cmd/api/app/types/api/v1/namespace.go

@@ -16,8 +16,11 @@ limitations under the License.
 
 package v1
 
+// CreateNamesapceRequest is the request body for creating a namespace.
 type CreateNamesapceRequest struct {
 	Name                string `json:"name" required:"true"`
 	SkipAutoPropagation bool   `json:"skipAutoPropagation"`
 }
+
+// CreateNamesapceResponse is the response body for creating a namespace.
 type CreateNamesapceResponse struct{}