update ut

Signed-off-by: zach593 <[email protected]>

Author: zach593

Diff for: pkg/util/ratelimiter.go

@@ -1,5 +1,5 @@
 /*
-Copyright 2024 The Karmada Authors.
+Copyright 2025 The Karmada Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
@@ -52,16 +52,16 @@ func (r *RateLimiterGetter) GetRateLimiter(key string) flowcontrol.RateLimiter {
 	if r.limiters == nil {
 		r.limiters = make(map[string]flowcontrol.RateLimiter)
 	}
-	qps := r.qps
-	if qps <= 0 {
-		qps = 5
-	}
-	burst := r.burst
-	if burst <= 0 {
-		burst = 10
-	}
 	limiter, ok := r.limiters[key]
 	if !ok {
+		qps := r.qps
+		if qps <= 0 {
+			qps = 5
+		}
+		burst := r.burst
+		if burst <= 0 {
+			burst = 10
+		}
 		limiter = flowcontrol.NewTokenBucketRateLimiter(qps, burst)
 		r.limiters[key] = limiter
 	}

Diff for: pkg/util/ratelimiter_test.go

@@ -0,0 +1,118 @@
+/*
+Copyright 2025 The Karmada Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package util
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"k8s.io/client-go/util/flowcontrol"
+)
+
+func TestGetRateLimiterGetter(t *testing.T) {
+	tests := []struct {
+		name string
+		want *RateLimiterGetter
+	}{
+		{
+			name: "get the default singleton",
+			want: defaultRateLimiterGetter,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			assert.Equalf(t, tt.want, GetRateLimiterGetter(), "GetRateLimiterGetter()")
+		})
+	}
+}
+
+func TestRateLimiterGetter_GetRateLimiter(t *testing.T) {
+	tests := []struct {
+		name   string
+		getter *RateLimiterGetter
+		want   flowcontrol.RateLimiter
+	}{
+		{
+			name:   "if qps/burst not set, use default value",
+			getter: &RateLimiterGetter{},
+			want:   flowcontrol.NewTokenBucketRateLimiter(5, 10),
+		},
+		{
+			name: "SetLimits() should able to work",
+			getter: func() *RateLimiterGetter {
+				getter := &RateLimiterGetter{}
+				getter.SetLimits(100, 200)
+				return getter
+			}(),
+			want: flowcontrol.NewTokenBucketRateLimiter(100, 200),
+		},
+		{
+			name: "if qps/burst invalid, use default value",
+			getter: func() *RateLimiterGetter {
+				getter := &RateLimiterGetter{}
+				getter.SetLimits(-1, -1)
+				return getter
+			}(),
+			want: flowcontrol.NewTokenBucketRateLimiter(5, 10),
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			assert.Equalf(t, tt.want, tt.getter.GetRateLimiter("a"), "GetRateLimiter()")
+		})
+	}
+}
+
+func TestRateLimiterGetter_GetSameRateLimiter(t *testing.T) {
+	type args struct {
+		key1 string
+		key2 string
+	}
+	tests := []struct {
+		name            string
+		args            args
+		wantSameLimiter bool
+	}{
+		{
+			name: "for a single cluster, the same limiter instance is obtained each time",
+			args: args{
+				key1: "a",
+				key2: "a",
+			},
+			wantSameLimiter: true,
+		},
+		{
+			name: "the rate limiter is independent for each cluster",
+			args: args{
+				key1: "a",
+				key2: "b",
+			},
+			wantSameLimiter: false,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			getter := &RateLimiterGetter{}
+			rl1 := getter.GetRateLimiter(tt.args.key1)
+			rl2 := getter.GetRateLimiter(tt.args.key2)
+			gotSameLimiter := rl1 == rl2
+			assert.Equalf(t, tt.wantSameLimiter, gotSameLimiter,
+				"key1: %v, key2: %v, wantSameLimiter: %v, rl1: %p, rl2: %p",
+				tt.args.key1, tt.args.key2, tt.wantSameLimiter, rl1, rl2)
+		})
+	}
+}