Skip to content

Commit 49adbf8

Browse files
varshith257varshith257
committed
refactor
Signed-off-by: Vamshi Maskuri <[email protected]> add review comments Signed-off-by: Vamshi Maskuri <[email protected]> fix lint
1 parent 23cbfdc commit 49adbf8

File tree

1 file changed

+305
-5
lines changed

1 file changed

+305
-5
lines changed

‎pkg/scheduler/scheduler_test.go

+305-5
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package scheduler
1818

1919
import (
2020
"context"
21+
"fmt"
2122
"reflect"
2223
"testing"
2324
"time"
@@ -26,23 +27,35 @@ import (
2627
"k8s.io/apimachinery/pkg/runtime"
2728
dynamicfake "k8s.io/client-go/dynamic/fake"
2829
"k8s.io/client-go/kubernetes/fake"
30+
"k8s.io/client-go/tools/record"
2931

3032
workv1alpha2 "github.com/karmada-io/karmada/pkg/apis/work/v1alpha2"
3133
karmadafake "github.com/karmada-io/karmada/pkg/generated/clientset/versioned/fake"
3234
"github.com/karmada-io/karmada/pkg/util"
35+
"github.com/karmada-io/karmada/pkg/util/grpcconnection"
3336
)
3437

3538
func TestCreateScheduler(t *testing.T) {
3639
dynamicClient := dynamicfake.NewSimpleDynamicClient(runtime.NewScheme())
3740
karmadaClient := karmadafake.NewSimpleClientset()
3841
kubeClient := fake.NewSimpleClientset()
3942
port := 10025
43+
servicePrefix := "test-service-prefix"
44+
schedulerName := "test-scheduler"
45+
timeout := metav1.Duration{Duration: 5 * time.Second}
4046

4147
testcases := []struct {
42-
name string
43-
opts []Option
44-
enableSchedulerEstimator bool
45-
schedulerEstimatorPort int
48+
name string
49+
opts []Option
50+
enableSchedulerEstimator bool
51+
schedulerEstimatorPort int
52+
disableSchedulerEstimatorInPullMode bool
53+
schedulerEstimatorTimeout metav1.Duration
54+
schedulerEstimatorServicePrefix string
55+
schedulerName string
56+
schedulerEstimatorClientConfig *grpcconnection.ClientConfig
57+
enableEmptyWorkloadPropagation bool
58+
plugins []string
4659
}{
4760
{
4861
name: "scheduler with default configuration",
@@ -66,6 +79,53 @@ func TestCreateScheduler(t *testing.T) {
6679
},
6780
enableSchedulerEstimator: false,
6881
},
82+
{
83+
name: "scheduler with disableSchedulerEstimatorInPullMode enabled",
84+
opts: []Option{
85+
WithEnableSchedulerEstimator(true),
86+
WithSchedulerEstimatorConnection(port, "", "", "", false),
87+
WithDisableSchedulerEstimatorInPullMode(true),
88+
},
89+
enableSchedulerEstimator: true,
90+
schedulerEstimatorPort: port,
91+
disableSchedulerEstimatorInPullMode: true,
92+
},
93+
{
94+
name: "scheduler with SchedulerEstimatorServicePrefix enabled",
95+
opts: []Option{
96+
WithEnableSchedulerEstimator(true),
97+
WithSchedulerEstimatorConnection(port, "", "", "", false),
98+
WithSchedulerEstimatorServicePrefix(servicePrefix),
99+
},
100+
enableSchedulerEstimator: true,
101+
schedulerEstimatorPort: port,
102+
schedulerEstimatorServicePrefix: servicePrefix,
103+
},
104+
{
105+
name: "scheduler with SchedulerName enabled",
106+
opts: []Option{
107+
WithSchedulerName(schedulerName),
108+
},
109+
schedulerName: schedulerName,
110+
},
111+
{
112+
name: "scheduler with EnableEmptyWorkloadPropagation enabled",
113+
opts: []Option{
114+
WithEnableEmptyWorkloadPropagation(true),
115+
},
116+
enableEmptyWorkloadPropagation: true,
117+
},
118+
{
119+
name: "scheduler with SchedulerEstimatorTimeout enabled",
120+
opts: []Option{
121+
WithEnableSchedulerEstimator(true),
122+
WithSchedulerEstimatorConnection(port, "", "", "", false),
123+
WithSchedulerEstimatorTimeout(timeout),
124+
},
125+
enableSchedulerEstimator: true,
126+
schedulerEstimatorPort: port,
127+
schedulerEstimatorTimeout: timeout,
128+
},
69129
}
70130

71131
for _, tc := range testcases {
@@ -82,10 +142,25 @@ func TestCreateScheduler(t *testing.T) {
82142
if tc.enableSchedulerEstimator && tc.schedulerEstimatorPort != sche.schedulerEstimatorClientConfig.TargetPort {
83143
t.Errorf("unexpected schedulerEstimatorPort want %v, got %v", tc.schedulerEstimatorPort, sche.schedulerEstimatorClientConfig.TargetPort)
84144
}
145+
146+
if tc.disableSchedulerEstimatorInPullMode != sche.disableSchedulerEstimatorInPullMode {
147+
t.Errorf("unexpected disableSchedulerEstimatorInPullMode want %v, got %v", tc.disableSchedulerEstimatorInPullMode, sche.disableSchedulerEstimatorInPullMode)
148+
}
149+
150+
if tc.schedulerEstimatorServicePrefix != sche.schedulerEstimatorServicePrefix {
151+
t.Errorf("unexpected schedulerEstimatorServicePrefix want %v, got %v", tc.schedulerEstimatorServicePrefix, sche.schedulerEstimatorServicePrefix)
152+
}
153+
154+
if tc.schedulerName != sche.schedulerName {
155+
t.Errorf("unexpected schedulerName want %v, got %v", tc.schedulerName, sche.schedulerName)
156+
}
157+
158+
if tc.enableEmptyWorkloadPropagation != sche.enableEmptyWorkloadPropagation {
159+
t.Errorf("unexpected enableEmptyWorkloadPropagation want %v, got %v", tc.enableEmptyWorkloadPropagation, sche.enableEmptyWorkloadPropagation)
160+
}
85161
})
86162
}
87163
}
88-
89164
func Test_patchBindingStatusCondition(t *testing.T) {
90165
oneHourBefore := time.Now().Add(-1 * time.Hour).Round(time.Second)
91166
oneHourAfter := time.Now().Add(1 * time.Hour).Round(time.Second)
@@ -500,3 +575,228 @@ func Test_patchClusterBindingStatusWithAffinityName(t *testing.T) {
500575
})
501576
}
502577
}
578+
579+
func Test_recordScheduleResultEventForResourceBinding(t *testing.T) {
580+
fakeRecorder := record.NewFakeRecorder(10)
581+
scheduler := &Scheduler{eventRecorder: fakeRecorder}
582+
583+
tests := []struct {
584+
name string
585+
rb *workv1alpha2.ResourceBinding
586+
scheduleResult []workv1alpha2.TargetCluster
587+
schedulerErr error
588+
expectedEvents int
589+
expectedMsg string
590+
}{
591+
{
592+
name: "nil ResourceBinding",
593+
rb: nil,
594+
scheduleResult: nil,
595+
schedulerErr: nil,
596+
expectedEvents: 0,
597+
expectedMsg: "",
598+
},
599+
{
600+
name: "successful scheduling",
601+
rb: &workv1alpha2.ResourceBinding{
602+
Spec: workv1alpha2.ResourceBindingSpec{
603+
Resource: workv1alpha2.ObjectReference{
604+
Kind: "Deployment",
605+
APIVersion: "apps/v1",
606+
Namespace: "default",
607+
Name: "test-deployment",
608+
UID: "12345",
609+
},
610+
},
611+
},
612+
scheduleResult: []workv1alpha2.TargetCluster{
613+
{Name: "cluster1", Replicas: 1},
614+
{Name: "cluster2", Replicas: 2},
615+
},
616+
schedulerErr: nil,
617+
expectedEvents: 2,
618+
expectedMsg: fmt.Sprintf("%s Result: {%s}", successfulSchedulingMessage, targetClustersToString([]workv1alpha2.TargetCluster{
619+
{Name: "cluster1", Replicas: 1},
620+
{Name: "cluster2", Replicas: 2},
621+
}))},
622+
{
623+
name: "scheduling error",
624+
rb: &workv1alpha2.ResourceBinding{
625+
Spec: workv1alpha2.ResourceBindingSpec{
626+
Resource: workv1alpha2.ObjectReference{
627+
Kind: "Deployment",
628+
APIVersion: "apps/v1",
629+
Namespace: "default",
630+
Name: "test-deployment",
631+
UID: "12345",
632+
},
633+
},
634+
},
635+
scheduleResult: nil,
636+
schedulerErr: fmt.Errorf("scheduling error"),
637+
expectedEvents: 2,
638+
expectedMsg: "scheduling error",
639+
},
640+
}
641+
642+
for _, test := range tests {
643+
t.Run(test.name, func(t *testing.T) {
644+
fakeRecorder.Events = make(chan string, 10)
645+
646+
scheduler.recordScheduleResultEventForResourceBinding(test.rb, test.scheduleResult, test.schedulerErr)
647+
648+
if len(fakeRecorder.Events) != test.expectedEvents {
649+
t.Errorf("expected %d events, got %d", test.expectedEvents, len(fakeRecorder.Events))
650+
}
651+
652+
for i := 0; i < test.expectedEvents; i++ {
653+
select {
654+
case event := <-fakeRecorder.Events:
655+
if !contains(event, test.expectedMsg) {
656+
t.Errorf("expected event message to contain %q, got %q", test.expectedMsg, event)
657+
}
658+
default:
659+
t.Error("expected event not found")
660+
}
661+
}
662+
})
663+
}
664+
}
665+
666+
func contains(event, msg string) bool {
667+
return len(event) >= len(msg) && event[len(event)-len(msg):] == msg
668+
}
669+
670+
func Test_recordScheduleResultEventForClusterResourceBinding(t *testing.T) {
671+
fakeRecorder := record.NewFakeRecorder(10)
672+
scheduler := &Scheduler{eventRecorder: fakeRecorder}
673+
674+
tests := []struct {
675+
name string
676+
crb *workv1alpha2.ClusterResourceBinding
677+
scheduleResult []workv1alpha2.TargetCluster
678+
schedulerErr error
679+
expectedEvents int
680+
expectedMsg string
681+
}{
682+
{
683+
name: "nil ClusterResourceBinding",
684+
crb: nil,
685+
scheduleResult: nil,
686+
schedulerErr: nil,
687+
expectedEvents: 0,
688+
expectedMsg: "",
689+
},
690+
{
691+
name: "successful scheduling",
692+
crb: &workv1alpha2.ClusterResourceBinding{
693+
Spec: workv1alpha2.ResourceBindingSpec{
694+
Resource: workv1alpha2.ObjectReference{
695+
Kind: "Deployment",
696+
APIVersion: "apps/v1",
697+
Namespace: "default",
698+
Name: "test-deployment",
699+
UID: "12345",
700+
},
701+
},
702+
},
703+
scheduleResult: []workv1alpha2.TargetCluster{
704+
{Name: "cluster1", Replicas: 1},
705+
{Name: "cluster2", Replicas: 2},
706+
},
707+
schedulerErr: nil,
708+
expectedEvents: 2,
709+
expectedMsg: fmt.Sprintf("%s Result {%s}", successfulSchedulingMessage, targetClustersToString([]workv1alpha2.TargetCluster{
710+
{Name: "cluster1", Replicas: 1},
711+
{Name: "cluster2", Replicas: 2},
712+
})),
713+
},
714+
{
715+
name: "scheduling error",
716+
crb: &workv1alpha2.ClusterResourceBinding{
717+
Spec: workv1alpha2.ResourceBindingSpec{
718+
Resource: workv1alpha2.ObjectReference{
719+
Kind: "Deployment",
720+
APIVersion: "apps/v1",
721+
Namespace: "default",
722+
Name: "test-deployment",
723+
UID: "12345",
724+
},
725+
},
726+
},
727+
scheduleResult: nil,
728+
schedulerErr: fmt.Errorf("scheduling error"),
729+
expectedEvents: 2,
730+
expectedMsg: "scheduling error",
731+
},
732+
}
733+
734+
for _, test := range tests {
735+
t.Run(test.name, func(t *testing.T) {
736+
fakeRecorder.Events = make(chan string, 10)
737+
738+
scheduler.recordScheduleResultEventForClusterResourceBinding(test.crb, test.scheduleResult, test.schedulerErr)
739+
740+
if len(fakeRecorder.Events) != test.expectedEvents {
741+
t.Errorf("expected %d events, got %d", test.expectedEvents, len(fakeRecorder.Events))
742+
}
743+
744+
for i := 0; i < test.expectedEvents; i++ {
745+
select {
746+
case event := <-fakeRecorder.Events:
747+
if !contains(event, test.expectedMsg) {
748+
t.Errorf("expected event message to contain %q, got %q", test.expectedMsg, event)
749+
}
750+
default:
751+
t.Error("expected event not found")
752+
}
753+
}
754+
})
755+
}
756+
}
757+
758+
func Test_targetClustersToString(t *testing.T) {
759+
tests := []struct {
760+
name string
761+
tcs []workv1alpha2.TargetCluster
762+
expectedOutput string
763+
}{
764+
{
765+
name: "empty slice",
766+
tcs: []workv1alpha2.TargetCluster{},
767+
expectedOutput: "",
768+
},
769+
{
770+
name: "single cluster",
771+
tcs: []workv1alpha2.TargetCluster{
772+
{Name: "cluster1", Replicas: 1},
773+
},
774+
expectedOutput: "cluster1:1",
775+
},
776+
{
777+
name: "multiple clusters",
778+
tcs: []workv1alpha2.TargetCluster{
779+
{Name: "cluster1", Replicas: 1},
780+
{Name: "cluster2", Replicas: 2},
781+
},
782+
expectedOutput: "cluster1:1, cluster2:2",
783+
},
784+
{
785+
name: "clusters with zero replicas",
786+
tcs: []workv1alpha2.TargetCluster{
787+
{Name: "cluster1", Replicas: 0},
788+
{Name: "cluster2", Replicas: 2},
789+
},
790+
expectedOutput: "cluster1:0, cluster2:2",
791+
},
792+
}
793+
794+
for _, test := range tests {
795+
t.Run(test.name, func(t *testing.T) {
796+
result := targetClustersToString(test.tcs)
797+
if result != test.expectedOutput {
798+
t.Errorf("expected %q, got %q", test.expectedOutput, result)
799+
}
800+
})
801+
}
802+
}

0 commit comments

Comments
 (0)