Skip to content

Commit b2f37bc

Browse files
Added tests for pkg/util/fedinformer
Signed-off-by: Anuj Agrawal <[email protected]>
1 parent a41ef50 commit b2f37bc

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

pkg/util/fedinformer/handlers_test.go

+11-11
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@ package fedinformer
1919
import (
2020
"testing"
2121

22-
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
22+
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2323
"k8s.io/apimachinery/pkg/runtime"
2424
"k8s.io/client-go/tools/cache"
2525
)
2626

2727
type TestObject struct {
28-
v1.TypeMeta
29-
v1.ObjectMeta
28+
metav1.TypeMeta
29+
metav1.ObjectMeta
3030
Spec string
3131
}
3232

@@ -66,14 +66,14 @@ func TestNewHandlerOnAllEvents(t *testing.T) {
6666

6767
handler := &CustomResourceEventHandler{NewHandlerOnAllEvents(fn)}
6868

69-
testObj := &TestObject{ObjectMeta: v1.ObjectMeta{Name: "test-obj"}}
69+
testObj := &TestObject{ObjectMeta: metav1.ObjectMeta{Name: "test-obj"}}
7070

7171
handler.OnAdd(testObj, false)
7272
if calledWith != testObj {
7373
t.Errorf("AddFunc: expected %v, got %v", testObj, calledWith)
7474
}
7575

76-
newObj := &TestObject{ObjectMeta: v1.ObjectMeta{Name: "test-obj"}, Spec: "updated"}
76+
newObj := &TestObject{ObjectMeta: metav1.ObjectMeta{Name: "test-obj"}, Spec: "updated"}
7777
handler.OnUpdate(testObj, newObj)
7878
if calledWith != newObj {
7979
t.Errorf("UpdateFunc: expected %v, got %v", newObj, calledWith)
@@ -99,14 +99,14 @@ func TestNewHandlerOnEvents(t *testing.T) {
9999

100100
handler := &CustomResourceEventHandler{NewHandlerOnEvents(addFunc, updateFunc, deleteFunc)}
101101

102-
testObj := &TestObject{ObjectMeta: v1.ObjectMeta{Name: "test-obj"}}
102+
testObj := &TestObject{ObjectMeta: metav1.ObjectMeta{Name: "test-obj"}}
103103

104104
handler.OnAdd(testObj, false)
105105
if !addCalled {
106106
t.Error("AddFunc was not called")
107107
}
108108

109-
newObj := &TestObject{ObjectMeta: v1.ObjectMeta{Name: "test-obj"}, Spec: "updated"}
109+
newObj := &TestObject{ObjectMeta: metav1.ObjectMeta{Name: "test-obj"}, Spec: "updated"}
110110
handler.OnUpdate(testObj, newObj)
111111
if !updateCalled {
112112
t.Error("UpdateFunc was not called")
@@ -131,29 +131,29 @@ func TestNewFilteringHandlerOnAllEvents(t *testing.T) {
131131

132132
handler := NewFilteringHandlerOnAllEvents(filterFunc, addFunc, updateFunc, deleteFunc)
133133

134-
passingObj := &TestObject{ObjectMeta: v1.ObjectMeta{Name: "passing-obj"}, Spec: "pass"}
134+
passingObj := &TestObject{ObjectMeta: metav1.ObjectMeta{Name: "passing-obj"}, Spec: "pass"}
135135
handler.OnAdd(passingObj, false)
136136
if !addCalled {
137137
t.Error("AddFunc was not called for passing object")
138138
}
139139

140140
addCalled = false
141-
failingObj := &TestObject{ObjectMeta: v1.ObjectMeta{Name: "failing-obj"}, Spec: "fail"}
141+
failingObj := &TestObject{ObjectMeta: metav1.ObjectMeta{Name: "failing-obj"}, Spec: "fail"}
142142
handler.OnAdd(failingObj, false)
143143
if addCalled {
144144
t.Error("AddFunc was called for failing object")
145145
}
146146

147147
updateCalled = false
148-
newPassingObj := &TestObject{ObjectMeta: v1.ObjectMeta{Name: "passing-obj"}, Spec: "pass"}
148+
newPassingObj := &TestObject{ObjectMeta: metav1.ObjectMeta{Name: "passing-obj"}, Spec: "pass"}
149149
handler.OnUpdate(passingObj, newPassingObj)
150150
if !updateCalled {
151151
t.Error("UpdateFunc was not called for passing objects")
152152
}
153153

154154
updateCalled = false
155155
deleteCalled = false
156-
newFailingObj := &TestObject{ObjectMeta: v1.ObjectMeta{Name: "passing-obj"}, Spec: "fail"}
156+
newFailingObj := &TestObject{ObjectMeta: metav1.ObjectMeta{Name: "passing-obj"}, Spec: "fail"}
157157
handler.OnUpdate(passingObj, newFailingObj)
158158
if updateCalled {
159159
t.Error("UpdateFunc was called for failing new object")

0 commit comments

Comments
 (0)