A deployment with a GPU request can still be deployed to a member cluster without a GPU Node

[chaunceyjiang]

What would you like to be added:

I hope that a deployment with GPU resources can only be deployed to member clusters with GPU nodes.

apiVersion: apps/v1
kind: Deployment
metadata:
  name: device-plugin
spec:
  replicas: 2
  selector:
    matchLabels:
      app: device-plugin
  template:
    metadata:
      labels:
        app: device-plugin
    spec:
      containers:
        - name: device-plugin
          image: busybox
          command: ["/bin/sh", "-ec", "while :; do echo '.'; sleep 5 ; done"]
          resources:
            limits:
              cpu: 2500m
              memory: 100Mi
              nvidia.com/vgpu: '1'
---
apiVersion: policy.karmada.io/v1alpha1
kind: PropagationPolicy
metadata:
  name: device-plugin-pp
spec:
  resourceSelectors:
  - apiVersion: apps/v1
    kind: Deployment
    name: device-plugin
  placement :
    clusterAffinity:
      clusterNames :
        - member1
        - member2
        - member3
    replicaScheduling:
      replicaDivisionPreference: Weighted
      replicaSchedulingType: Divided
#      weightPreference:
#        dynamicWeight: AvailableReplicas

Why is this needed:

A deployment with a GPU request cannot start normally on a cluster without GPU nodes.

[chaunceyjiang]

#3318

Perhaps we can filter out clusters without GPU nodes at the preFilter stage.

[chaosi-zju]

I have tested and confirmed as a problem.

besides, you gave a good scenario for #3318

[tedli]

Hi all,

FYI,

We met the same problem.

karmada/pkg/util/resource.go

Lines 52 to 73 in 7395a8b

	func (r *Resource) Add(rl corev1.ResourceList) {
	if r == nil {
	return
	}
	for rName, rQuant := range rl {
	switch rName {
	case corev1.ResourceCPU:
	r.MilliCPU += rQuant.MilliValue()
	case corev1.ResourceMemory:
	r.Memory += rQuant.Value()
	case corev1.ResourcePods:
	r.AllowedPodNumber += rQuant.Value()
	case corev1.ResourceEphemeralStorage:
	r.EphemeralStorage += rQuant.Value()
	default:
	if lifted.IsScalarResourceName(rName) {
	r.AddScalar(rName, rQuant.Value())
	}
	}
	}
	}

tried to make line 68 lifted.IsScalarResourceName(rName) happy, can fix this issue.

[chaunceyjiang]

Hi, @tedli Can you attend the meeting tomorrow afternoon (December 19th, at 2:30 PM)? I hope to discuss the current issue with you.

[tedli]

Hi @chaunceyjiang ,
I will be there until 3:00 PM, unfortunately after 3:00, there is another meeting that I have to attend.