-
Notifications
You must be signed in to change notification settings - Fork 1k
adjust the Priority of General and Accurate Estimator of Karmada Scheduler #4398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4398 +/- ##
==========================================
+ Coverage 51.82% 51.84% +0.02%
==========================================
Files 244 246 +2
Lines 24238 24378 +140
==========================================
+ Hits 12561 12639 +78
- Misses 10995 11049 +54
- Partials 682 690 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Just a question, will this modification require compatibility? Will it force users to upgrade the Estimator component? |
I don't think it matters. What do you think?
I think it's only about the scheduler, and doesn't require upgrading estimator |
|
/lgtm |
|
/lgtm |
|
CC @RainbowMango may be ready to merge, any further comments? |
1cd8b0b to
3255438
Compare
3255438 to
f46a564
Compare
|
@whitewindmills sorry for delayed a while, I have updated the code, do you have time checking once more? |
b1f44ba to
842aef3
Compare
ec1eaa0 to
73310c3
Compare
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
73310c3 to
808b10e
Compare
808b10e to
b4e22fb
Compare
…duler Signed-off-by: chaosi-zju <[email protected]>
b4e22fb to
2a208c7
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
If the accurate estimator is enabled and
karmada-scheduler-estimatorcomponents also are enabled, the accurate estimator should be prior toResourceModelingrather than using the minumal value of them.Which issue(s) this PR fixes:
Fixes #3333
Special notes for your reviewer:
CC @lonelyCZ @whitewindmills
Does this PR introduce a user-facing change?: