Skip to content

Commit d38561e

Browse files
author
Kartik Raj
committed
Modify telemetry to contain trigger time as property
1 parent 75ed73e commit d38561e

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

src/client/languageServer/watcher.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,9 @@ export class LanguageServerWatcher implements IExtensionActivationService, ILang
178178
// Start the language server.
179179
if (startupStopWatch) {
180180
// It means that startup is triggering this code, track time it takes since startup to activate this code.
181-
sendTelemetryEvent(EventName.LANGUAGE_SERVER_TRIGGER_DURATION, startupStopWatch.elapsedTime);
181+
sendTelemetryEvent(EventName.LANGUAGE_SERVER_TRIGGER_DURATION, undefined, {
182+
triggerTime: startupStopWatch.elapsedTime,
183+
});
182184
}
183185
await languageServerExtensionManager.startLanguageServer(lsResource, interpreter);
184186

src/client/telemetry/index.ts

+7-2
Original file line numberDiff line numberDiff line change
@@ -1330,10 +1330,15 @@ export interface IEventNamePropertyMapping {
13301330
*/
13311331
/* __GDPR__
13321332
"language_server_trigger_duration" : {
1333-
"duration" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "owner": "karrtikr", "isMeasurement": true }
1333+
"triggerTime" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true, "owner": "karrtikr" },
13341334
}
13351335
*/
1336-
[EventName.LANGUAGE_SERVER_TRIGGER_DURATION]: unknown;
1336+
[EventName.LANGUAGE_SERVER_TRIGGER_DURATION]: {
1337+
/**
1338+
* Time it took to trigger language server startup.
1339+
*/
1340+
triggerTime: number;
1341+
};
13371342
/**
13381343
* Telemetry event sent when starting Node.js server
13391344
*/

0 commit comments

Comments
 (0)