Merge pull request Dash-Industry-Forum#1331 from bbc/repratiobound

Dan Sparacio · Dan Sparacio · commit 6ad7c03f2336 · 2016-04-14T16:54:10.000-07:00
Prevent low values attempting to use representation -1
diff --git a/src/streaming/controllers/AbrController.js b/src/streaming/controllers/AbrController.js
@@ -141,7 +141,8 @@ function AbrController() {
                 let representation = dashManifestModel.getAdaptationForType(manifest, 0, type).Representation;
 
                 if (Array.isArray(representation)) {
-                    bitrateDict[type] = representation[Math.round(representation.length * ratioDict[type]) - 1].bandwidth;
+                    let repIdx = Math.max(Math.round(representation.length * ratioDict[type]) - 1, 0);
+                    bitrateDict[type] = representation[repIdx].bandwidth;
                 } else {
                     bitrateDict[type] = 0;
                 }

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,8 @@ function AbrController() {`
`141`	`141`	`let representation = dashManifestModel.getAdaptationForType(manifest, 0, type).Representation;`
`142`	`142`
`143`	`143`	`if (Array.isArray(representation)) {`
`144`		`- bitrateDict[type] = representation[Math.round(representation.length * ratioDict[type]) - 1].bandwidth;`
	`144`	`+ let repIdx = Math.max(Math.round(representation.length * ratioDict[type]) - 1, 0);`
	`145`	`+ bitrateDict[type] = representation[repIdx].bandwidth;`
`145`	`146`	`} else {`
`146`	`147`	`bitrateDict[type] = 0;`
`147`	`148`	`}`