Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Update image version #2919

Closed
wants to merge 1 commit into from
Closed

📖 Update image version #2919

wants to merge 1 commit into from

Conversation

mjudeikis
Copy link
Contributor

@mjudeikis mjudeikis commented Mar 24, 2023 •
edited
Loading

Summary

0.7 does not work with the current main. If somebody follows by letter, it breaks.

Related issue(s)

Fixes kcp-dev/contrib-tmc#29

@openshift-ci openshift-ci bot requested review from ncdc and stevekuznetsov March 24, 2023 10:54
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sttts for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mjudeikis mjudeikis changed the title 📖 update image version 📖 Update image version Mar 24, 2023
hardys
hardys reviewed Mar 27, 2023
View reviewed changes
docs/content/concepts/registering-kubernetes-clusters-using-syncer.md
@@ -46,7 +46,7 @@ To register a Kubernetes cluster with kcp, you have to install a special compone
kubectl kcp workload sync <synctarget name> --syncer-image <image name> -o syncer.yaml
```

Where `<image name>` [one of the syncer images](https://github.com/kcp-dev/kcp/pkgs/container/kcp%2Fsyncer) for your corresponding KCP release (e.g. `ghcr.io/kcp-dev/kcp/syncer:v0.7.5`).
Where `<image name>` [one of the syncer images](https://github.com/kcp-dev/kcp/pkgs/container/kcp%2Fsyncer) for your corresponding KCP release (e.g. `ghcr.io/kcp-dev/kcp/syncer:v0.11.0`).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image also has a main tag, I wonder if we should use that for the main version of the docs?

To avoid this getting outdated again, we could say something like "... for your corresponding KCP release, or main for the development version (e.g. ghcr.io/kcp-dev/kcp/syncer:main )."

@kcp-ci-bot kcp-ci-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2023
@kcp-ci-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjudeikis mjudeikis closed this Oct 14, 2023
@kcp-ci-bot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardys hardys hardys left review comments

@ncdc ncdc Awaiting requested review from ncdc

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees
No one assigned
Labels
do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: docs 0.11 pointing to syncer image 0.10
3 participants
@mjudeikis @kcp-ci-bot @hardys