Skip to content

Commit 82c1f1c

Browse files
committed
fix(fallback): play around with fallback logic some more
1 parent d697e45 commit 82c1f1c

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

src/document.rs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -354,12 +354,15 @@ impl KdlDocument {
354354
let v2_res = KdlDocument::parse_v2(s);
355355
if v2_res.is_err() {
356356
let v1_res = KdlDocument::parse_v2(s);
357-
if v1_res.is_err() && detect_v2(s) {
358-
v2_res
359-
} else if detect_v1(s) {
357+
if v1_res.is_ok() || detect_v1(s) {
360358
v1_res
359+
} else if detect_v2(s) {
360+
// v2, but with confidence
361+
v2_res
361362
} else {
362-
// This does matter, because detection short-circuits.
363+
// TODO(@zkat): maybe we can add something to the error
364+
// message to specify that it's "uncertain"?
365+
// YOLO.
363366
v2_res
364367
}
365368
} else {

0 commit comments

Comments
 (0)