Merge pull request #312 from kabiroberai/kabir/fix-networklogger-deadlock

kean · web-flow · commit 07cad099e1a3 · 2024-12-17T19:42:57.000-05:00
Fix deadlock in NetworkLogger
diff --git a/Sources/Pulse/NetworkLogger/NetworkLogger.swift b/Sources/Pulse/NetworkLogger/NetworkLogger.swift
@@ -161,6 +161,7 @@ public final class NetworkLogger: @unchecked Sendable {
     public func logTaskCreated(_ task: URLSessionTask) {
         lock.lock()
         guard tasks[TaskKey(task: task)] == nil else {
+            lock.unlock()
             return // Already registered
         }
         let context = context(for: task)

Original file line number	Diff line number	Diff line change
`@@ -161,6 +161,7 @@ public final class NetworkLogger: @unchecked Sendable {`
`161`	`161`	`public func logTaskCreated(_ task: URLSessionTask) {`
`162`	`162`	`lock.lock()`
`163`	`163`	`guard tasks[TaskKey(task: task)] == nil else {`
	`164`	`+ lock.unlock()`
`164`	`165`	`return // Already registered`
`165`	`166`	`}`
`166`	`167`	`let context = context(for: task)`