Skip to content

Commit 41df6a0

Browse files
committed
Minor design improvements
1 parent ea09a55 commit 41df6a0

File tree

4 files changed

+14
-12
lines changed

4 files changed

+14
-12
lines changed

Sources/PulseUI/Features/Console/List/ConsoleListContentView.swift

+3-1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ struct ConsoleListContentView: View {
2323
Text("Empty")
2424
.font(.subheadline)
2525
.foregroundColor(.secondary)
26+
.listRowInsets(EdgeInsets(top: 12, leading: 20, bottom: 12, trailing: 16))
2627
} else {
2728
ForEach(viewModel.visibleEntities, id: \.objectID) { entity in
2829
let objectID = entity.objectID
@@ -33,11 +34,12 @@ struct ConsoleListContentView: View {
3334
.onDisappear { viewModel.onDisappearCell(with: objectID) }
3435
#endif
3536
#if os(iOS)
36-
.listRowInsets(EdgeInsets(top: 10, leading: 20, bottom: 10, trailing: 16))
37+
.listRowInsets(EdgeInsets(top: 12, leading: 20, bottom: 12, trailing: 16))
3738
#endif
3839
}
3940
}
4041
footerView
42+
.listRowInsets(EdgeInsets(top: 12, leading: 20, bottom: 12, trailing: 16))
4143
}
4244

4345
@ViewBuilder

Sources/PulseUI/Features/Console/List/ConsoleListView.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ private struct _ConsoleListView: View {
6969
ConsoleSearchListContentView()
7070
} else {
7171
ConsoleToolbarView()
72-
.listRowSeparator(.hidden, edges: .top)
72+
.listRowSeparator(.hidden, edges: .all)
7373
ConsoleListContentView()
7474
}
7575
}

Sources/PulseUI/Features/Console/Views/ConsoleMessageCell.swift

+7-8
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,13 @@ struct ConsoleMessageCell: View {
3939
.foregroundColor(titleColor)
4040
Spacer()
4141
Components.makePinView(for: message)
42-
HStack(spacing: 3) {
43-
ConsoleTimestampView(date: message.createdAt)
44-
.overlay(alignment: .trailing) {
45-
if isDisclosureNeeded {
46-
ListDisclosureIndicator()
47-
.offset(x: 11, y: 0)
48-
}
49-
}
42+
ConsoleTimestampView(date: message.createdAt)
43+
.padding(.trailing, 3)
44+
}
45+
.overlay(alignment: .trailing) {
46+
if isDisclosureNeeded {
47+
ListDisclosureIndicator()
48+
.offset(x: 8, y: 0)
5049
}
5150
}
5251
}

Sources/PulseUI/Features/Console/Views/ConsoleTaskCell.swift

+3-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ struct ConsoleTaskCell: View {
2121
var body: some View {
2222
VStack(alignment: .leading, spacing: 3) {
2323
header
24+
content // .padding(.top, 4)
2425
details
25-
content.padding(.top, 3)
2626
}
2727
}
2828

@@ -36,6 +36,7 @@ struct ConsoleTaskCell: View {
3636
info
3737
Spacer()
3838
ConsoleTimestampView(date: task.createdAt)
39+
.padding(.trailing, 3)
3940
}
4041
.overlay(alignment: .leading) {
4142
StatusIndicatorView(state: task.state(in: store))
@@ -44,7 +45,7 @@ struct ConsoleTaskCell: View {
4445
.overlay(alignment: .trailing) {
4546
if isDisclosureNeeded {
4647
ListDisclosureIndicator()
47-
.offset(x: 11)
48+
.offset(x: 8)
4849
}
4950
}
5051
}

0 commit comments

Comments
 (0)