Improve ConsoleTaskCell default design

kean · kean · commit 4bf636e895bc · 2024-09-09T21:25:16.000-04:00
diff --git a/Sources/PulseUI/Features/Console/Views/ConsoleMessageCell.swift b/Sources/PulseUI/Features/Console/Views/ConsoleMessageCell.swift
@@ -44,14 +44,13 @@ struct ConsoleMessageCell: View {
             Spacer()
             Components.makePinView(for: message)
             HStack(spacing: 3) {
-                Text(ConsoleMessageCell.timeFormatter.string(from: message.createdAt))
-                    .lineLimit(1)
-                    .font(detailsFont)
-                    .monospacedDigit()
-                    .foregroundColor(.secondary)
-                if isDisclosureNeeded {
-                    ListDisclosureIndicator()
-                }
+                ConsoleTimestampView(date: message.createdAt)
+                    .overlay(alignment: .trailing) {
+                        if isDisclosureNeeded {
+                            ListDisclosureIndicator()
+                                .offset(x: 11, y: 0)
+                        }
+                    }
             }
         }
     }
@@ -91,11 +90,9 @@ struct ConsoleMessageCell: View {
 struct ListDisclosureIndicator: View {
     var body: some View {
         Image(systemName: "chevron.right")
-            .foregroundColor(Color.separator)
             .lineLimit(1)
-            .font(ConsoleConstants.fontTitle)
-            .foregroundColor(.secondary)
-            .padding(.trailing, -12)
+            .font(.caption2.weight(.bold))
+            .foregroundColor(.secondary.opacity(0.33))
     }
 }
 
diff --git a/Sources/PulseUI/Features/Console/Views/ConsoleTaskCell.swift b/Sources/PulseUI/Features/Console/Views/ConsoleTaskCell.swift
@@ -7,6 +7,184 @@ import Pulse
 import Combine
 import CoreData
 
+#if os(iOS)
+
+@available(iOS 15, visionOS 1.0, *)
+struct ConsoleTaskCell: View {
+    @ObservedObject var task: NetworkTaskEntity
+    var isDisclosureNeeded = false
+
+    @ScaledMetric(relativeTo: .body) private var fontMultiplier = 1.0
+    @ObservedObject private var settings: UserSettings = .shared
+    @Environment(\.store) private var store: LoggerStore
+
+    var body: some View {
+        VStack(alignment: .leading, spacing: 6) {
+            header
+            content
+            footer
+        }
+    }
+
+    // MARK: – Header
+
+    // TODO: add missing "Mock" badge
+    private var header: some View {
+        HStack {
+            StatusIndicatorView(state: task.state(in: store))
+            info
+            Spacer()
+            ConsoleTimestampView(date: task.createdAt)
+                .overlay(alignment: .trailing) {
+                    if isDisclosureNeeded {
+                        ListDisclosureIndicator()
+                            .offset(x: 11)
+                    }
+                }
+        }
+    }
+
+    private var info: some View {
+        var text: Text {
+            let status = Text(ConsoleFormatter.status(for: task, store: store))
+                .font(.footnote.weight(.medium))
+
+            guard settings.displayOptions.isShowingDetails else {
+                return status
+            }
+            let details = settings.displayOptions.detailsFields
+                .compactMap(makeInfoText)
+                .joined(separator: " · ")
+            guard !details.isEmpty else {
+                return status
+            }
+            return status + Text(" · \(details)").font(.footnote)
+        }
+        return text
+            .tracking(-0.3)
+            .lineLimit(1)
+            .foregroundStyle(.secondary)
+    }
+
+
+    private func makeInfoText(for detail: DisplayOptions.Field) -> String? {
+        switch detail {
+        case .method: 
+            task.httpMethod
+        case .requestSize:
+            byteCount(for: task.requestBodySize)
+        case .responseSize:
+            byteCount(for: task.responseBodySize)
+        case .responseContentType:
+            task.responseContentType.map(NetworkLogger.ContentType.init)?.lastComponent.uppercased()
+        case .duration:
+            ConsoleFormatter.duration(for: task)
+        case .host:
+            task.host
+        case .statusCode:
+            task.statusCode != 0 ? task.statusCode.description : nil
+        case .taskType:
+            NetworkLogger.TaskType(rawValue: task.taskType)?.urlSessionTaskClassName
+        case .taskDescription:
+            task.taskDescription
+        }
+    }
+
+    // MARK: – Content
+
+    private var content: some View {
+        var method: Text? {
+            guard let method = task.httpMethod else {
+                return nil
+            }
+            return Text(method.appending(" "))
+                .font(contentFont.weight(.medium).smallCaps())
+                .tracking(-0.3)
+        }
+
+        var main: Text {
+            Text(task.getFormattedContent(options: settings.displayOptions) ?? "–")
+                .font(contentFont)
+        }
+
+        var text: Text {
+            if let method {
+                method + main
+            } else {
+                main
+            }
+        }
+
+        return text
+            .lineLimit(settings.displayOptions.contentLineLimit)
+    }
+
+    // MARK: – Footer
+
+    @ViewBuilder
+    private var footer: some View {
+        if let host = task.host, !host.isEmpty {
+            Text(host)
+                .lineLimit(1)
+                .font(.footnote)
+                .foregroundStyle(.secondary)
+        }
+    }
+
+    // MARK: - Helpers
+
+    private var contentFont: Font {
+        let baseSize = CGFloat(settings.displayOptions.contentFontSize)
+        return Font.system(size: baseSize * fontMultiplier)
+    }
+
+    private var detailsFont: Font {
+        let baseSize = CGFloat(settings.displayOptions.detailsFontSize)
+        return Font.system(size: baseSize * fontMultiplier).monospacedDigit()
+    }
+
+    private func byteCount(for size: Int64) -> String {
+        guard size > 0 else { return "0 KB" }
+        return ByteCountFormatter.string(fromByteCount: size)
+    }
+}
+
+private struct StatusIndicatorView: View {
+    let state: NetworkTaskEntity.State?
+
+    var body: some View {
+        Image(systemName: "circle.fill")
+            .foregroundStyle(color)
+            .font(.system(size: 9))
+            .clipShape(RoundedRectangle(cornerRadius: 3))
+    }
+
+    private var color: Color {
+        guard let state else {
+            return .secondary
+        }
+        switch state {
+        case .pending: return .orange
+        case .success: return .green
+        case .failure: return .red
+        }
+    }
+}
+
+struct ConsoleTimestampView: View {
+    let date: Date
+
+    var body: some View {
+        Text(ConsoleMessageCell.timeFormatter.string(from: date))
+            .font(.caption)
+            .monospacedDigit()
+            .tracking(-0.5)
+            .foregroundStyle(.secondary)
+    }
+}
+
+#else
+
 @available(iOS 15, visionOS 1.0, *)
 struct ConsoleTaskCell: View {
     @ObservedObject var task: NetworkTaskEntity
@@ -135,7 +313,7 @@ struct ConsoleTaskCell: View {
             Text(task.httpMethod ?? "GET")
         case .requestSize: 
             makeInfoText("arrow.up", byteCount(for: task.requestBodySize))
-        case .responseSize: 
+        case .responseSize:
             makeInfoText("arrow.down", byteCount(for: task.responseBodySize))
         case .responseContentType:
             task.responseContentType.map(NetworkLogger.ContentType.init).map {
@@ -211,6 +389,8 @@ private let titleSpacing: CGFloat = 20
 private let titleSpacing: CGFloat? = nil
 #endif
 
+#endif
+
 @available(iOS 15, visionOS 1.0, *)
 struct MockBadgeView: View {
     var body: some View {
@@ -248,3 +428,4 @@ struct ConsoleTaskCell_Previews: PreviewProvider {
     }
 }
 #endif
+
diff --git a/Sources/PulseUI/Helpers/UserSettings.swift b/Sources/PulseUI/Helpers/UserSettings.swift
@@ -150,7 +150,7 @@ public final class UserSettings: ObservableObject {
         }
 
         public init(
-            detailsFields: [Field] = [.method, .requestSize, .responseSize, .duration]
+            detailsFields: [Field] = [.responseSize, .duration]
         ) {
             self.detailsFields = detailsFields
         }
diff --git a/Sources/PulseUI/Mocks/MockTask.swift b/Sources/PulseUI/Mocks/MockTask.swift
@@ -302,7 +302,7 @@ private let mockReposBody = Bundle.main.url(forResource: "repos", withExtension:
 
 // MARK: - /CreateAPI (GET, redirect)
 
-private let mockCreateAPIOriginalRequest = URLRequest(url: "https://github.com/CreateAPI/Get")
+private let mockCreateAPIOriginalRequest = URLRequest(url: "https://github.com/createapi/get")
 
 private let mockCreateAPICurrentRequest = mockCreateAPIOriginalRequest.adding(headers: [
     "User-Agent": "Pulse Demo/2.0",
@@ -311,22 +311,22 @@ private let mockCreateAPICurrentRequest = mockCreateAPIOriginalRequest.adding(he
     "Accept": "text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8"
 ])
 
-private let mockCreateAPIRedirectRequest = URLRequest(url: "https://github.com/kean/Get").adding(headers: [
+private let mockCreateAPIRedirectRequest = URLRequest(url: "https://github.com/kean/get").adding(headers: [
     "User-Agent": "Pulse Demo/2.0",
     "Accept-Encoding": "gzip",
     "Accept-Language": "en-us",
     "Accept": "text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8"
 ])
 
-private let mockCreateaAPIRedirectResponse = HTTPURLResponse(url: "https://github.com/CreateAPI/Get", statusCode: 301, headers: [
+private let mockCreateaAPIRedirectResponse = HTTPURLResponse(url: "https://github.com/createapi/get", statusCode: 301, headers: [
     "Content-Type": "text/html; charset=utf-8",
     "Location": "https://github.com/kean/Get",
     "Cache-Control": "no-cache",
     "Content-Length": "0",
     "Server": "GitHub.com"
 ])
 
-private let mockCreateaAPIResponse = HTTPURLResponse(url: "https://github.com/kean/Get", statusCode: 200, headers: [
+private let mockCreateaAPIResponse = HTTPURLResponse(url: "https://github.com/kean/get", statusCode: 200, headers: [
     "Content-Type": "text/html; charset=utf-8",
     "Content-Length": "90",
     "Cache-Control": "no-store"
@@ -349,7 +349,7 @@ private let mockCreateaAPIBody = """
 // MARK: - PATCH
 
 private let mockPatchRepoOriginalRequest: URLRequest = {
-    var request = URLRequest(url: "https://github.com/repos/kean/Nuke", method: "PATCH")
+    var request = URLRequest(url: "https://github.com/repos/kean/nuke", method: "PATCH")
     request.httpBody = """
     name=ImageKit&description=Image%20Loading%Framework&private=false
     """.data(using: .utf8)
@@ -364,7 +364,7 @@ private let mockPatchRepoCurrentRequest = mockPatchRepoOriginalRequest.adding(he
     "Accept": "application/vnd.github+json"
 ])
 
-private let mockPatchRepoResponse = HTTPURLResponse(url: "https://github.com/repos/kean/Nuke", statusCode: 200, headers: [
+private let mockPatchRepoResponse = HTTPURLResponse(url: "https://github.com/repos/kean/nuke", statusCode: 200, headers: [
     "Content-Length": "165061",
     "Content-Type": "application/json; charset=utf-8",
     "Cache-Control": "no-store",
@@ -447,7 +447,7 @@ private let mockPatchRepoDecodingError: Error = {
 
 // MARK: - Download (GET)
 
-private let mockDownloadNukeOriginalRequest = URLRequest(url: "https://github.com/kean/Nuke/archive/tags/11.0.0.zip")
+private let mockDownloadNukeOriginalRequest = URLRequest(url: "https://github.com/kean/nuke/archive/tags/11.0.0.zip")
 
 private let mockDownloadNukeCurrentRequest = mockDownloadNukeOriginalRequest.adding(headers: [
     "User-Agent": "Pulse Demo/2.0",
@@ -456,7 +456,7 @@ private let mockDownloadNukeCurrentRequest = mockDownloadNukeOriginalRequest.add
     "Accept": "*/*"
 ])
 
-private let mockDownloadNukeRedirectResponse = HTTPURLResponse(url: "https://codeload.github.com/kean/Nuke/zip/tags/11.0.0", statusCode: 302, headers: [
+private let mockDownloadNukeRedirectResponse = HTTPURLResponse(url: "https://codeload.github.com/kean/nuke/zip/tags/11.0.0", statusCode: 302, headers: [
     "Server": "GitHub.com",
     "Content-Type": "text/html; charset=utf-8",
     "Location": "https://codeload.github.com/kean/Nuke/zip/tags/11.0.0",
@@ -465,7 +465,7 @@ private let mockDownloadNukeRedirectResponse = HTTPURLResponse(url: "https://cod
     "Content-Security-Policy": "default-src 'none'; base-uri 'self'; block-all-mixed-content; child-src github.com/assets-cdn/worker/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com objects-origin.githubusercontent.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com cdn.optimizely.com logx.optimizely.com/v1/events *.actions.githubusercontent.com wss://*.actions.githubusercontent.com online.visualstudio.com/api/v1/locations github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com"
 ])
 
-private let mockDownloadNukeResponse = HTTPURLResponse(url: "https://codeload.github.com/kean/Nuke/zip/tags/11.0.0", statusCode: 200, headers: [
+private let mockDownloadNukeResponse = HTTPURLResponse(url: "https://codeload.github.com/kean/nuke/zip/tags/11.0.0", statusCode: 200, headers: [
     "Content-Type": "application/zip",
     "Content-Disposition": "attachment; filename=Nuke-11.0.0.zip",
     "Etag": "W/\\\"4358c3c3d9bd5a22f6d86b47cbe567417fa1efc8df6beaa54c1730caf6ad86da\\\"",

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ public final class UserSettings: ObservableObject {`
`150`	`150`	`}`
`151`	`151`
`152`	`152`	`public init(`
`153`		`- detailsFields: [Field] = [.method, .requestSize, .responseSize, .duration]`
	`153`	`+ detailsFields: [Field] = [.responseSize, .duration]`
`154`	`154`	`) {`
`155`	`155`	`self.detailsFields = detailsFields`
`156`	`156`	`}`