Add error handling for automatic resitration

Author: kean

Sources/Pulse/NetworkLogger/URLSessionProxy.swift

@@ -19,7 +19,11 @@ public final class URLSessionProxy {
     /// - parameter logger: The network logger to be used for recording the requests.
     public static func enable(with logger: NetworkLogger = .init()) {
         guard URLSessionProxy.proxy == nil else {
-            NSLog("Pulse.URLSessionProxy already enabled")
+            NSLog("Error: Pulse.URLSessionProxy already enabled")
+            return
+        }
+        guard sharedNetworkLogger == nil else {
+            NSLog("Error: Pulse network request logging is already enabled")
             return
         }
         let proxy = URLSessionProxy(logger: logger)
@@ -34,7 +38,7 @@ public final class URLSessionProxy {
             swizzleDataTaskDidReceiveData(baseClass: sessionClass)
             swizzleDataDataDidCompleteWithError(baseClass: sessionClass)
         } else {
-            NSLog("URLSessionProxy failed to initialize. Please report at https://github.com/kean/Pulse/issues.")
+            NSLog("Pulse.URLSessionProxy failed to initialize. Please report at https://github.com/kean/Pulse/issues.")
         }
     }
 

Sources/Pulse/NetworkLogger/URLSessionProxyDelegate+AutomaticRegistration.swift

@@ -9,16 +9,21 @@ extension URLSessionProxyDelegate {
     /// you initialize a `URLSession` using `init(configuration:delegate:delegateQueue:))` method, the
     /// delegate will automatically get replaced with a `URLSessionProxyDelegate` that logs all the
     /// needed events and forwards the methods to your original delegate.
+    @MainActor
     public static func enableAutomaticRegistration(logger: NetworkLogger = .init()) {
-        sharedLogger = logger
+        guard sharedNetworkLogger == nil else {
+            NSLog("Error: Puls network request logging is already enabled")
+            return
+        }
+        sharedNetworkLogger = logger
         if let lhs = class_getClassMethod(URLSession.self, #selector(URLSession.init(configuration:delegate:delegateQueue:))),
            let rhs = class_getClassMethod(URLSession.self, #selector(URLSession.pulse_init(configuration:delegate:delegateQueue:))) {
             method_exchangeImplementations(lhs, rhs)
         }
     }
 }
 
-private var sharedLogger: NetworkLogger? {
+var sharedNetworkLogger: NetworkLogger? {
     get { _sharedLogger.value }
     set { _sharedLogger.value = newValue }
 }
@@ -30,11 +35,11 @@ private extension URLSession {
             return self.pulse_init(configuration: configuration, delegate: delegate, delegateQueue: delegateQueue)
         }
         configuration.protocolClasses = [RemoteLoggerURLProtocol.self] + (configuration.protocolClasses ?? [])
-        guard let sharedLogger else {
+        guard let sharedNetworkLogger else {
             assertionFailure("Shared logger is missing")
             return self.pulse_init(configuration: configuration, delegate: delegate, delegateQueue: delegateQueue)
         }
-        let delegate = URLSessionProxyDelegate(logger: sharedLogger, delegate: delegate)
+        let delegate = URLSessionProxyDelegate(logger: sharedNetworkLogger, delegate: delegate)
         return self.pulse_init(configuration: configuration, delegate: delegate, delegateQueue: delegateQueue)
     }
 }