Don't fail when we can't find an AutoValue Builder setter method #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelloggm
approved these changes
Nov 18, 2019
There was a problem hiding this comment.
I would expect one of the new tests you added to fail due to the lack of support for extensions, but it doesn't look like any of them are skipped. Can you explain why?
Do we have a test that would only pass if we did support extensions? If so, can you add it with an @skip-test annotation at the top of the test?
|
Sorry for the confusion. The test passes because this PR disables the check for a matching builder setter. The test fails on current master with a RuntimeException. I will update comments to be clearer |
msridhar
referenced
this pull request
in msridhar/object-construction-checker
Nov 19, 2019
Before, we would fail with a `RuntimeException` if we couldn't match what we thought was an AutoValue property to a corresponding setter in the builder. But, we don't currently handle AutoValue extensions (see #110), and adding full and proper handling will be pretty non-trivial. So, instead of failing for these cases, just tolerate them. Add a test case using the AutoValue Parcel extension to expose the problem, along with some stub Android classes so we don't need to pull in a full Android dependence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we would fail with a
RuntimeExceptionif we couldn't match what we thought was an AutoValue property to a corresponding setter in the builder. But, we don't currently handle AutoValue extension (see #110), and adding full and proper handling will be pretty non-trivial. So, instead of failing for these cases, just tolerate them.Add a test case using the AutoValue Parcel extension to expose the problem, along with some stub Android classes so we don't need to pull in a full Android dependence.