introduce bugs in programs

Author: yashhere

armstrong.c

@@ -1,10 +1,21 @@
+/*********
+
+Author1 Name:
+Author2 Name:
+
+FIXED THE BUGS FOR GIT-WORKSHOP
+
+**********/
+
 #include <stdio.h>
 int main()
 {
     int number, originalNumber, remainder, result = 0;
 
     printf("Enter a three digit integer: ");
-    scanf("%d", &number);
+	
+	// HERE IS THE BUG, PUT A '&' IN FRONT OF number.
+    scanf("%d", number);
 
     originalNumber = number;
 

arraySearch.c

@@ -1,3 +1,11 @@
+/*********
+
+Author1 Name:
+Author2 Name:
+
+FIXED THE BUGS FOR GIT-WORKSHOP
+
+**********/
 #include<stdio.h>
 
 int main() {
@@ -15,8 +23,9 @@ int main() {
    printf("\nEnter the elements to be searched :");
    scanf("%d", &ele);
 
-   //Search starts from the zeroth location
-   i = 0;
+   
+   // HERE IS THE BUG, WE MISSED THE FIRST ELEMENT OF THE ARRAY. CHANGE i=1 to i=0
+   i = 1;
    while (i < num && ele != a[i]) {
       i++;
    }

average.c

@@ -1,27 +1,30 @@
+/*********
+
+Author1 Name:
+Author2 Name:
+
+FIXED THE BUGS FOR GIT-WORKSHOP
+
+**********/
 #include <stdio.h>
 
 int main()
 {
     int n, i;
-    float num[100], sum = 0.0, average;
+    float num[100], sum = 0.0;
 
     printf("Enter the numbers of elements: ");
     scanf("%d", &n);
 
-    while (n > 100 || n <= 0)
-    {
-        printf("Error! number should in range of (1 to 100).\n");
-        printf("Enter the number again: ");
-        scanf("%d", &n);
-    }
-
     for(i = 0; i < n; ++i)
     {
         printf("%d. Enter number: ", i+1);
         scanf("%f", &num[i]);
         sum += num[i];
     }
 
+	// HERE IS THE BUG, average is declared as int, that will give wrong output. CHANGE int average TO float average.
+	int average;
     average = sum / n;
     printf("Average = %.2f", average);
 

binarySearch.c

@@ -1,3 +1,11 @@
+/*********
+
+Author1 Name:
+Author2 Name:
+
+FIXED THE BUGS FOR GIT-WORKSHOP
+
+**********/
 #include<stdio.h>
 int main(){
 
@@ -15,7 +23,9 @@ int main(){
     scanf("%d",&m);
 
     l=0,u=n-1;
-    while(l<=u){
+	
+	// HERE IS THE BUG, THE CONDITION SHOULD BE (l<=u).
+    while(l<u){
          mid=(l+u)/2;
          if(m==a[mid]){
              c=1;

bubbleSort.c

@@ -1,42 +1,44 @@
+/*********
+
+Author1 Name:
+Author2 Name:
+
+FIXED THE BUGS FOR GIT-WORKSHOP
+
+**********/
 #include<stdio.h>
-#include<conio.h>
 
 void bubble_sort(int[], int);
 
 void main() {
    int arr[30], num, i;
 
-   printf("\nEnter no of elements :");
+   printf("Enter no of elements :");
    scanf("%d", &num);
 
-   printf("\nEnter array elements :");
+   printf("Enter array elements :");
    for (i = 0; i < num; i++)
       scanf("%d", &arr[i]);
 
    bubble_sort(arr, num);
-   getch();
+   printf("\n");
 }
 
+
+// HERE IS THE BUG, IN THE INNER LOOP, CHANGE j < num to j < num-1
 void bubble_sort(int iarr[], int num) {
    int i, j, k, temp;
- 
-   printf("\nUnsorted Data:");
-   for (k = 0; k < num; k++) {
-      printf("%5d", iarr[k]);
-   }
- 
    for (i = 1; i < num; i++) {
-      for (j = 0; j < num - 1; j++) {
+      for (j = 0; j < num; j++) {
          if (iarr[j] > iarr[j + 1]) {
             temp = iarr[j];
             iarr[j] = iarr[j + 1];
             iarr[j + 1] = temp;
          }
       }
- 
-      printf("\nAfter pass %d : ", i);
-      for (k = 0; k < num; k++) {
-         printf("%5d", iarr[k]);
-      }
    }
+   
+	for (k = 0; k < num; k++) {
+         printf("%5d", iarr[k]);
+	}
 }

evenorodd.c

@@ -1,3 +1,11 @@
+/*********
+
+Author1 Name:
+Author2 Name:
+
+FIXED THE BUGS FOR GIT-WORKSHOP
+
+**********/
 #include<stdio.h>
 
 int main(){
@@ -7,7 +15,8 @@ int main(){
     printf("Enter any integer: ");
     scanf("%d",&number);
 
-    if(number % 2 ==0)
+	// HERE IS THE BUG, number % 2 == 0 means even
+    if(number % 2 != 0)
          printf("%d is even number.",number);
     else
          printf("%d is odd number.",number);

factorial.c

@@ -1,3 +1,11 @@
+/*********
+
+Author1 Name:
+Author2 Name:
+
+FIXED THE BUGS FOR GIT-WORKSHOP
+
+**********/
 #include <stdio.h>
 int main()
 {
@@ -7,15 +15,15 @@ int main()
     printf("Enter an integer: ");
     scanf("%d",&n);
 
-    // show error if the user enters a negative integer
     if (n < 0)
         printf("Error! Factorial of a negative number doesn't exist.");
 
     else
     {
-        for(i=1; i<=n; ++i)
+		// HERE IS THE BUG, CHANGE i<n to i<=n
+        for(i=1; i<n; ++i)
         {
-            factorial *= i;              // factorial = factorial*i;
+            factorial *= i;
         }
         printf("Factorial of %d = %llu", n, factorial);
     }

fibonacci.c

@@ -1,3 +1,13 @@
+/*********
+
+Author1 Name:
+Author2 Name:
+
+FIXED THE BUGS FOR GIT-WORKSHOP
+
+**********/
+
+// NO BUGS IN THIS PROGRAM
 #include <stdio.h>
 
 main()

gcd.c

@@ -1,10 +1,20 @@
+/*********
+
+Author1 Name:
+Author2 Name:
+
+FIXED THE BUGS FOR GIT-WORKSHOP
+
+**********/
 #include <stdio.h>
 int main()
 {
     int n1, n2, i, gcd;
 
     printf("Enter two integers: ");
-    scanf("%d %d", &n1, &n2);
+	
+	// HERE IS THE BUG, ADD '&' in front of n1
+    scanf("%d %d", n1, &n2);
 
     for(i=1; i <= n1 && i <= n2; ++i)
     {

greatestof3.c

@@ -1,3 +1,13 @@
+/*********
+
+Author1 Name:
+Author2 Name:
+
+FIXED THE BUGS FOR GIT-WORKSHOP
+
+**********/
+
+// NO BUGS IN THIS PROGRAM
 #include<stdio.h>
 
 int main() {
@@ -7,13 +17,13 @@ int main() {
    scanf("%d %d %d", &a, &b, &c);
 
    if ((a > b) && (a > c))
-      printf("\na is greatest");
+      printf("\a is greatest");
 
    if ((b > c) && (b > a))
-      printf("\nb is greatest");
+      printf("\b is greatest");
 
    if ((c > a) && (c > b))
-      printf("\nc is greatest");
+      printf("\c is greatest");
 
    return(0);
 }

largest.c

@@ -1,3 +1,11 @@
+/*********
+
+Author1 Name:
+Author2 Name:
+
+FIXED THE BUGS FOR GIT-WORKSHOP
+
+**********/
 #include <stdio.h>
 
 int main()
@@ -13,7 +21,9 @@ int main()
     for(i = 0; i < n; ++i)
     {
        printf("Enter Number %d: ", i+1);
-       scanf("%f", &arr[i]);
+	   
+	   // HERE IS THE BUG, PUT '&' IN FRONT OF arr[i]
+       scanf("%f", arr[i]);
     }
 
     // Loop to store largest number to arr[0]

leap.c

@@ -1,3 +1,11 @@
+/*********
+
+Author1 Name:
+Author2 Name:
+
+FIXED THE BUGS FOR GIT-WORKSHOP
+
+**********/
 #include <stdio.h>
 
 int main()
@@ -11,8 +19,8 @@ int main()
     {
         if( year%100 == 0)
         {
-            // year is divisible by 400, hence the year is a leap year
-            if ( year%400 == 0)
+			// HERE IS THE BUG, WHEN YEAR%400 == 0, THEN IT IS LEAP YEAR!!
+            if ( year%400 != 0)
                 printf("%d is a leap year.", year);
             else
                 printf("%d is not a leap year.", year);

lenString.c

@@ -1,3 +1,11 @@
+/*********
+
+Author1 Name:
+Author2 Name:
+
+FIXED THE BUGS FOR GIT-WORKSHOP
+
+**********/
 #include <stdio.h>
 int main()
 {
@@ -8,6 +16,7 @@ int main()
 
     for(i = 0; s[i] != '\0'; ++i);
 
-    printf("Length of string: %d", i);
+	// HERE IS THE BUG, LENGTH OF THE STRING WILL BE EQUAL TO i, not (i-1)
+    printf("Length of string: %d", i-1);
     return 0;
 }

lowertoupper.c

@@ -1,14 +1,23 @@
+/*********
+
+Author1 Name:
+Author2 Name:
+
+FIXED THE BUGS FOR GIT-WORKSHOP
+
+**********/
 #include<stdio.h>
 int main(){
   char str[20];
   int i;
   printf("Enter any string->");
   scanf("%s",str);
-  printf("The string is->%s",str);
+  printf("The string is = %s",str);
   for(i=0;i<=strlen(str);i++){
-            if(str[i]>=97&&str[i]<=122)
-            str[i]=str[i]-32;
+	// HERE IS THE BUG, THE RANGE OF SMALL CASE LETTERS IS 97 TO 122.
+	if(str[i]>=98&&str[i]<=121)
+		str[i]=str[i]-32;
   }
-  printf("\nThe string in lowercase is->%s",str);
+  printf("\nThe string in lowercase is = %s",str);
   return 0;
 }