set Randomizer seed in Test Framework

Sets the seed for all mock data before running all tests
Refactor usage of Project.Projects.First() to a static property on Project.
Refactor usage of Uri.EscapeDataString to UrlEncode method on ApiTestBase
fix Terms aggregation partitioning test to use 10 partitions of size 5 so that partititon 0 has buckets

(cherry picked from commit d8273d0)

Author: russcam

docs/aggregations/writing-aggregations.asciidoc

@@ -144,6 +144,7 @@ return s => s
     );
 ----
 <1> a list of aggregation functions to apply
+
 <2> Using LINQ's `Aggregate()` function to accumulate/apply all of the aggregation functions
 
 Combining multipe `AggregationDescriptor`'s is also possible using the bitwise `&` operator
@@ -211,5 +212,6 @@ var maxPerChild = childAggregation.Max("max_per_child");
 maxPerChild.Should().NotBeNull(); <2>
 ----
 <1> Do something with the average per child. Here we just assert it's not null
+
 <2> Do something with the max per child. Here we just assert it's not null
 

docs/client-concepts/connection-pooling/request-overrides/disable-sniff-ping-per-request.asciidoc

@@ -64,7 +64,9 @@ new ClientCall()
 );
 ----
 <1> disable sniffing
+
 <2> first call is a successful ping
+
 <3> sniff on startup call happens here, on the second call
 
 Now, let's disable pinging on the request 
@@ -87,6 +89,7 @@ audit = await audit.TraceCall(
 );
 ----
 <1> disable ping
+
 <2> No ping after sniffing
 
 Finally, let's demonstrate disabling both sniff and ping on the request 
@@ -108,5 +111,6 @@ audit = await audit.TraceCall(
 );
 ----
 <1> diable ping and sniff
+
 <2> no ping or sniff before the call
 

docs/client-concepts/high-level/inference/field-inference.asciidoc

@@ -523,9 +523,13 @@ class Precedence
 }
 ----
 <1> Even though this property has a NEST property mapping _and_ a `JsonProperty` attribute, We are going to provide a hard rename for it on ConnectionSettings later that should win.
+
 <2> This property has both a NEST attribute and a `JsonProperty`, NEST should win.
+
 <3> We should take the json property into account by itself
+
 <4> This property we are going to special case in our custom serializer to resolve to ask
+
 <5> We are going to register a DefaultFieldNameInferrer on ConnectionSettings that will uppercase all properties.
 
 Here we create a custom serializer that renames any property named `AskSerializer` to `ask`

docs/client-concepts/high-level/inference/indices-paths.asciidoc

@@ -79,7 +79,9 @@ ISearchRequest singleTypedRequest = new SearchDescriptor<Project>().Index(single
 var invalidSingleString = Index("name1, name2"); <3>
 ----
 <1> specifying a single index using a string
+
 <2> specifying a single index using a type
+
 <3> an **invalid** single index name
 
 ==== Specifying multiple indices
@@ -111,7 +113,9 @@ manyStringRequest = new SearchDescriptor<Project>().Type(new[] { "name1", "name2
 ((IUrlParameter)manyStringRequest.Type).GetString(this.Client.ConnectionSettings).Should().Be("name1,name2");
 ----
 <1> specifying multiple indices using strings
+
 <2> specifying multiple indices using types
+
 <3> The index names here come from the Connection Settings passed to `TestClient`. See the documentation on <<index-name-inference, Index Name Inference>> for more details.
 
 ==== Specifying All Indices

docs/client-concepts/low-level/connecting.asciidoc

@@ -91,7 +91,9 @@ var client = new ElasticLowLevelClient(config);
 var result = client.Search<SearchResponse<object>>(new { size = 12 });
 ----
 <1> Disable automatic proxy detection. When called, defaults to `true`.
+
 <2> Enable compressed request and responses from Elasticsearch (Note that nodes need to be configured to allow this. See the {ref_current}/modules-http.html[http module settings] for more info).
+
 <3> By default responses are deserialized directly from the response stream to the object you tell it to. For debugging purposes, it can be very useful to keep a copy of the raw response on the result object, which is what calling this method will do.
 
 `.ResponseBodyInBytes` will only have a value if the client configuration has `DisableDirectStreaming` set 
@@ -129,9 +131,13 @@ config = config
     .BasicAuthentication("username", "password");
 ----
 <1> Allows you to set querystring parameters that have to be added to every request. For instance, if you use a hosted elasticserch provider, and you need need to pass an `apiKey` parameter onto every request.
+
 <2> Sets proxy information on the connection.
+
 <3> [[request-timeout]] Sets the global maximum time a connection may take. Please note that this is the request timeout, the builtin .NET `WebRequest` has no way to set connection timeouts (see http://msdn.microsoft.com/en-us/library/system.net.httpwebrequest.timeout(v=vs.110).aspx[the MSDN documentation on `HttpWebRequest.Timeout` Property]).
+
 <4> As an alternative to the C/go like error checking on `response.IsValid`, you can instead tell the client to <<thrown-exceptions, throw exceptions>>.
+
 <5> forces all serialization to be indented and appends `pretty=true` to all the requests so that the responses are indented as well
 
 NOTE: Basic authentication credentials can alternatively be specified on the node URI directly:
@@ -353,6 +359,8 @@ public class MyJsonNetSerializer : JsonNetSerializer
 }
 ----
 <1> Call this constructor if you only need access to `JsonSerializerSettings` without local state (properties on MyJsonNetSerializer)
+
 <2> Call OverwriteDefaultSerializers if you need access to `JsonSerializerSettings` with local state
+
 <3> You can inject contract resolved converters by implementing the ContractConverters property. This can be much faster then registering them on `JsonSerializerSettings.Converters`
 

src/CodeGeneration/DocGenerator/StringExtensions.cs

@@ -117,8 +117,8 @@ public static string[] SplitOnNewLines(this string input, StringSplitOptions opt
 		{
 			{ "FixedDate", "new DateTime(2015, 06, 06, 12, 01, 02, 123)" },
 			{ "FirstNameToFind", "\"pierce\"" },
-			{ "Project.Projects.First().Suggest.Context.Values.SelectMany(v => v).First()", "\"red\"" },
-			{ "Project.Projects.First().Suggest.Contexts.Values.SelectMany(v => v).First()", "\"red\"" },
+			{ "Project.First.Suggest.Context.Values.SelectMany(v => v).First()", "\"red\"" },
+			{ "Project.First.Suggest.Contexts.Values.SelectMany(v => v).First()", "\"red\"" },
 			{ "Project.Instance.Name", "\"Durgan LLC\"" },
 			{ "Project.InstanceAnonymous", "new {name = \"Koch, Collier and Mohr\", state = \"BellyUp\",startedOn = " +
 			                               "\"2015-01-01T00:00:00\",lastActivity = \"0001-01-01T00:00:00\",leadDeveloper = " +
@@ -128,9 +128,8 @@ public static string[] SplitOnNewLines(this string input, StringSplitOptions opt
 			{ "base.QueryJson", "new{ @bool = new { must = new[] { new { match_all = new { } } }, must_not = new[] { new { match_all = new { } } }, should = new[] { new { match_all = new { } } }, filter = new[] { new { match_all = new { } } }, minimum_should_match = 1, boost = 2.0, } }" },
 			{ "ExpectedTerms", "new [] { \"term1\", \"term2\" }" },
 			{ "_ctxNumberofCommits", "\"_source.numberOfCommits > 0\"" },
-			{ "Project.Projects.First().Name", "\"Lesch Group\"" },
-			{ "Project.Projects.FirstOrDefault().NumberOfCommits", "775" },
-			{ "Project.Projects.FirstOrDefault().Name", "\"Dickinson - Beier\"" },
+			{ "Project.First.Name", "\"Lesch Group\"" },
+			{ "Project.First.NumberOfCommits", "775" },
 			{ "LastNameSearch", "\"Stokes\"" }
 		};
 

src/Tests/Aggregations/Bucket/Filter/FilterAggregationUsageTests.cs

@@ -23,7 +23,7 @@ public FilterAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usage) : bas
 		{
 		}
 
-		public static string FirstNameToFind = Project.Projects.First().LeadDeveloper.FirstName.ToLowerInvariant();
+		public static string FirstNameToFind = Project.First.LeadDeveloper.FirstName.ToLowerInvariant();
 
 		protected override object ExpectJson => new
 		{

src/Tests/Aggregations/Bucket/Terms/TermsAggregationUsageTests.cs

@@ -353,11 +353,11 @@ public PartitionTermsAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usag
 					terms = new
 					{
 						field = "numberOfCommits",
-						size = 2,
+						size = 5,
 						include = new
 						{
 							partition = 0,
-							num_partitions = 50
+							num_partitions = 10
 						}
 					}
 				}
@@ -369,8 +369,8 @@ public PartitionTermsAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usag
 			.Aggregations(a => a
 				.Terms("commits", st => st
 					.Field(p => p.NumberOfCommits)
-					.Include(partition: 0, numberOfPartitions: 50)
-					.Size(2)
+					.Include(partition: 0, numberOfPartitions: 10)
+					.Size(5)
 				)
 			);
 
@@ -381,8 +381,8 @@ public PartitionTermsAggregationUsageTests(ReadOnlyCluster i, EndpointUsage usag
 				Aggregations = new TermsAggregation("commits")
 				{
 					Field = Infer.Field<Project>(p => p.NumberOfCommits),
-					Include = new TermsInclude(0, 50),
-					Size = 2
+					Include = new TermsInclude(0, 10),
+					Size = 5
 				}
 			};
 

src/Tests/ClientConcepts/Certificates/WorkingWithCertificates.doc.cs

@@ -60,9 +60,9 @@ protected override ConnectionSettings ConnectionSettings(ConnectionSettings s) =
 	}
 	//hide
 	[IntegrationOnly]
-	public class AllowAllSllCertificatesApiTests : CanConnectTestBase<AllowAllCertificatesCluster>
+	public class AllowAllSslCertificatesApiTests : CanConnectTestBase<AllowAllCertificatesCluster>
 	{
-		public AllowAllSllCertificatesApiTests(AllowAllCertificatesCluster cluster, EndpointUsage usage) : base(cluster, usage) { }
+		public AllowAllSslCertificatesApiTests(AllowAllCertificatesCluster cluster, EndpointUsage usage) : base(cluster, usage) { }
 		[I] public async Task UsedHttps() => await AssertOnAllResponses(r => r.ApiCall.Uri.Scheme.Should().Be("https"));
 	}
 

src/Tests/Cluster/TaskManagement/TasksCancel/TasksCancelApiTests.cs

@@ -59,7 +59,7 @@ protected override LazyResponses ClientUsage() => Calls(
 		protected override bool ExpectIsValid => true;
 		protected override int ExpectStatusCode => 200;
 		protected override HttpMethod HttpMethod => HttpMethod.POST;
-		protected override string UrlPath => $"/_tasks/{Uri.EscapeDataString(this.TaskId.ToString())}/_cancel";
+		protected override string UrlPath => $"/_tasks/{UrlEncode(this.TaskId.ToString())}/_cancel";
 		protected override bool SupportsDeserialization => false;
 
 

src/Tests/Document/Multiple/DeleteByQuery/DeleteByQueryApiTests.cs

@@ -54,7 +54,7 @@ protected override LazyResponses ClientUsage() => Calls(
 				ids = new
 				{
 					types = new[] { "project" },
-					values = new [] { Project.Projects.First().Name, "x" }
+					values = new [] { Project.First.Name, "x" }
 				}
 			}
 		};
@@ -67,7 +67,7 @@ protected override LazyResponses ClientUsage() => Calls(
 			.Query(q=>q
 				.Ids(ids=>ids
 					.Types(typeof(Project))
-					.Values(Project.Projects.First().Name, "x")
+					.Values(Project.First.Name, "x")
 				)
 			);
 
@@ -77,7 +77,7 @@ protected override LazyResponses ClientUsage() => Calls(
 			Query = new IdsQuery
 			{
 				Types = Types.Type<Project>(),
-				Values = new Id[] { Project.Projects.First().Name, "x" }
+				Values = new Id[] { Project.First.Name, "x" }
 			}
 		};
 

src/Tests/Document/Single/Get/GetApiTests.cs

@@ -13,11 +13,9 @@ namespace Tests.Document.Single.Get
 {
 	public class GetApiTests : ApiIntegrationTestBase<ReadOnlyCluster, IGetResponse<Project>, IGetRequest, GetDescriptor<Project>, GetRequest<Project>>
 	{
-		protected string ProjectId => Project.Projects.First().Name;
+		protected string ProjectId => Project.First.Name;
 
-		protected string ProjectIdForUrl => Uri.EscapeDataString(this.ProjectId);
-
-		public GetApiTests(ReadOnlyCluster cluster, EndpointUsage usage) : base(cluster, usage) { }
+	    public GetApiTests(ReadOnlyCluster cluster, EndpointUsage usage) : base(cluster, usage) { }
 		protected override LazyResponses ClientUsage() => Calls(
 			fluent: (client, f) => client.Get<Project>(this.ProjectId, f),
 			fluentAsync: (client, f) => client.GetAsync<Project>(this.ProjectId, f),
@@ -28,7 +26,7 @@ protected override LazyResponses ClientUsage() => Calls(
 		protected override bool ExpectIsValid => true;
 		protected override int ExpectStatusCode => 200;
 		protected override HttpMethod HttpMethod => HttpMethod.GET;
-		protected override string UrlPath => $"/project/project/{ProjectIdForUrl}";
+		protected override string UrlPath => $"/project/project/{UrlEncode(this.ProjectId)}";
 
 		protected override bool SupportsDeserialization => false;
 
@@ -47,9 +45,7 @@ public class GetNonExistentDocumentApiTests : ApiIntegrationTestBase<ReadOnlyClu
 	{
 		protected string ProjectId => this.CallIsolatedValue;
 
-		protected string ProjectIdForUrl => Uri.EscapeDataString(this.ProjectId);
-
-		public GetNonExistentDocumentApiTests(ReadOnlyCluster cluster, EndpointUsage usage) : base(cluster, usage) { }
+	    public GetNonExistentDocumentApiTests(ReadOnlyCluster cluster, EndpointUsage usage) : base(cluster, usage) { }
 		protected override LazyResponses ClientUsage() => Calls(
 			fluent: (client, f) => client.Get<Project>(this.ProjectId, f),
 			fluentAsync: (client, f) => client.GetAsync<Project>(this.ProjectId, f),
@@ -60,7 +56,7 @@ protected override LazyResponses ClientUsage() => Calls(
 		protected override bool ExpectIsValid => true;
 		protected override int ExpectStatusCode => 404;
 		protected override HttpMethod HttpMethod => HttpMethod.GET;
-		protected override string UrlPath => $"/project/project/{ProjectIdForUrl}";
+		protected override string UrlPath => $"/project/project/{UrlEncode(this.ProjectId)}";
 
 		protected override bool SupportsDeserialization => false;
 
@@ -83,11 +79,7 @@ public class GetApiParentTests : ApiIntegrationTestBase<ReadOnlyCluster, IGetRes
 
 		protected string CommitActivityId => CommitActivity.Id;
 
-		protected string ParentIdForUrl => Uri.EscapeDataString(this.CommitActivity.ProjectName);
-
-		protected string CommitActivityIdForUrl => Uri.EscapeDataString(this.CommitActivityId);
-
-		public GetApiParentTests(ReadOnlyCluster cluster, EndpointUsage usage) : base(cluster, usage) { }
+	    public GetApiParentTests(ReadOnlyCluster cluster, EndpointUsage usage) : base(cluster, usage) { }
 		protected override LazyResponses ClientUsage() => Calls(
 			fluent: (client, f) => client.Get<CommitActivity>(this.CommitActivityId, f),
 			fluentAsync: (client, f) => client.GetAsync<CommitActivity>(this.CommitActivityId, f),
@@ -98,7 +90,7 @@ protected override LazyResponses ClientUsage() => Calls(
 		protected override bool ExpectIsValid => true;
 		protected override int ExpectStatusCode => 200;
 		protected override HttpMethod HttpMethod => HttpMethod.GET;
-		protected override string UrlPath => $"/project/commits/{CommitActivityIdForUrl}?parent={ParentIdForUrl}";
+		protected override string UrlPath => $"/project/commits/{UrlEncode(this.CommitActivityId)}?parent={UrlEncode(this.CommitActivity.ProjectName)}";
 
 		protected override bool SupportsDeserialization => false;
 
@@ -126,7 +118,7 @@ public class GetApiFieldsTests : GetApiTests
 	{
 		public GetApiFieldsTests(ReadOnlyCluster cluster, EndpointUsage usage) : base(cluster, usage) { }
 
-		protected override string UrlPath => $"/project/project/{ProjectIdForUrl}?stored_fields=name%2CnumberOfCommits";
+		protected override string UrlPath => $"/project/project/{UrlEncode(this.ProjectId)}?stored_fields=name%2CnumberOfCommits";
 
 		protected override Func<GetDescriptor<Project>, IGetRequest> Fluent => g => g
 			.StoredFields(

src/Tests/Document/Single/TermVectors/TermVectorsApiTests.cs

@@ -24,7 +24,7 @@ protected override LazyResponses ClientUsage() => Calls(
 		protected override bool ExpectIsValid => true;
 		protected override int ExpectStatusCode => 200;
 		protected override HttpMethod HttpMethod => HttpMethod.POST;
-		protected override string UrlPath => $"/project/project/{Uri.EscapeDataString(Project.Instance.Name)}/_termvectors?offsets=true";
+		protected override string UrlPath => $"/project/project/{UrlEncode(Project.Instance.Name)}/_termvectors?offsets=true";
 
 		protected override bool SupportsDeserialization => false;
 

src/Tests/Document/Single/Update/UpdateWithSourceApiTests.cs

@@ -63,7 +63,7 @@ [I] public Task ReturnsSourceAndFields() => this.AssertOnAllResponses(r =>
 			r.Get.Should().NotBeNull();
 			r.Get.Found.Should().BeTrue();
 			r.Get.Source.Should().NotBeNull();
-			var name = Project.Projects.First().Name;
+			var name = Project.First.Name;
 			r.Get.Source.Name.Should().Be(name);
 			r.Get.Fields.Should().NotBeEmpty().And.ContainKey("name");
 			r.Get.Fields.Value<string>("name").Should().Be(name);

src/Tests/Framework/EndpointTests/ApiTestBase.cs

@@ -26,8 +26,9 @@ public abstract class ApiTestBase<TCluster, TResponse, TInterface, TDescriptor,
 
 		protected static string RandomString() => Guid.NewGuid().ToString("N").Substring(0, 8);
 		protected bool RanIntegrationSetup => this._usage?.CalledSetup ?? false;
+	    protected string UrlEncode(string s) => Uri.EscapeDataString(s);
 
-		protected ClusterBase Cluster { get; }
+        protected ClusterBase Cluster { get; }
 
 		protected string CallIsolatedValue => _uniqueValues.Value;
 		protected T ExtendedValue<T>(string key) where T : class => this._uniqueValues.ExtendedValue<T>(key);

src/Tests/Framework/MockData/Gimme.cs

@@ -5,12 +5,6 @@ namespace Tests.Framework.MockData
 {
 	internal static class Gimme
 	{
-		static Gimme()
-		{
-			Randomizer.Seed = new Random(1337);
-		}
-
 		public static Randomizer Random = new Randomizer();
-
 	}
 }

src/Tests/Framework/MockData/Project.cs

@@ -55,6 +55,8 @@ public class Project
 
 		public static IList<Project> Projects { get; } = Project.Generator.Generate(100).ToList();
 
+	    public static Project First { get; } = Projects.First();
+
 		public static Project Instance = new Project
 		{
 			Name = Projects.First().Name,

src/Tests/Framework/Xunit/TestFramework.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Reflection;
+using Bogus;
 using Tests.Framework;
 using Tests.Framework.Configuration;
 using Xunit.Abstractions;
@@ -16,7 +17,10 @@ public TestFramework(IMessageSink messageSink)
 		protected override ITestFrameworkExecutor CreateExecutor(AssemblyName assemblyName)
 		{
 			var config = TestClient.Configuration;
-			Console.WriteLine("Starting tests using config:");
+
+		    Randomizer.Seed = new Random(1337);
+
+            Console.WriteLine("Starting tests using config:");
 			Console.WriteLine($" - {nameof(config.TestAgainstAlreadyRunningElasticsearch)}: {config.TestAgainstAlreadyRunningElasticsearch}");
 			Console.WriteLine($" - {nameof(config.ElasticsearchVersion)}: {config.ElasticsearchVersion}");
 			Console.WriteLine($" - {nameof(config.ForceReseed)}: {config.ForceReseed}");

src/Tests/QueryDsl/Joining/ParentId/ParentIdUsageTests.cs

@@ -21,22 +21,22 @@ public ParentIdUsageTests(ReadOnlyCluster i, EndpointUsage usage) : base(i, usag
 			{
 				_name = "named_query",
 				type = "developer",
-				id = Project.Projects.First().Name
+				id = Project.First.Name
 			}
 		};
 
 		protected override QueryContainer QueryInitializer => new ParentIdQuery
 		{
 			Name = "named_query",
 			Type = Infer.Type<Developer>(),
-			Id = Project.Projects.First().Name
+			Id = Project.First.Name
 		};
 
 		protected override QueryContainer QueryFluent(QueryContainerDescriptor<Project> q) => q
 			.ParentId(p => p
 				.Name("named_query")
 				.Type<Developer>()
-				.Id(Project.Projects.First().Name)
+				.Id(Project.First.Name)
 			);
 
 		protected override ConditionlessWhen ConditionlessWhen => new ConditionlessWhen<IParentIdQuery>(a => a.ParentId)