Skip to content

Commit c9fc75f

Browse files
committed
Fix: rename 'timeout' containers to 'timeout_task' to avoid conflicts with docker keyword
Signed-off-by: Simone Tollardo <[email protected]>
1 parent c2469b6 commit c9fc75f

File tree

7 files changed

+27
-27
lines changed

7 files changed

+27
-27
lines changed

config/logger.conf

+9-9
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ keys=root,
1616
send_kcidb,
1717
tarball,
1818
test_report,
19-
timeout,
20-
timeout-closing,
21-
timeout-holdoff,
19+
timeout-task,
20+
timeout-task-closing,
21+
timeout-task-holdoff,
2222
trigger
2323

2424
[handlers]
@@ -113,22 +113,22 @@ handlers=consoleHandler, timedRotatingHandler
113113
qualname=test_report
114114
propagate=0
115115

116-
[logger_timeout]
116+
[logger_timeout-task]
117117
level=DEBUG
118118
handlers=consoleHandler, timedRotatingHandler
119-
qualname=timeout
119+
qualname=timeout-task
120120
propagate=0
121121

122-
[logger_timeout-closing]
122+
[logger_timeout-task-closing]
123123
level=DEBUG
124124
handlers=consoleHandler, timedRotatingHandler
125-
qualname=timeout-closing
125+
qualname=timeout-task-closing
126126
propagate=0
127127

128-
[logger_timeout-holdoff]
128+
[logger_timeout-task-holdoff]
129129
level=DEBUG
130130
handlers=consoleHandler, timedRotatingHandler
131-
qualname=timeout-holdoff
131+
qualname=timeout-task-holdoff
132132
propagate=0
133133

134134
[logger_trigger]

doc/pipeline-details.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ Each environment needs to have its own API token set up locally to be able to su
7474

7575
### Timeout
7676

77-
The timeout service periodically checks all nodes' state. If a node is not in "done" state, then it checks whether the maximum wait time (timeout) is over. If so, it sets the node and all its child nodes to "done" state.
77+
The timeout-task service periodically checks all nodes' state. If a node is not in "done" state, then it checks whether the maximum wait time (timeout) is over. If so, it sets the node and all its child nodes to "done" state.
7878
If the node is in "available" state and not timed-out, it will check for holdoff time. If the holdoff reached, and all its child nodes are completed, the node state will be moved to "done", otherwise the state will be set to "closing".
7979
The parent node with "closing" state can not have any new child nodes.
8080
This will generate pub/sub event of node update.

docker-compose.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ services:
184184
extra_hosts:
185185
- "host.docker.internal:host-gateway"
186186

187-
timeout:
187+
timeout-task:
188188
<<: *base-service
189189
container_name: 'kernelci-pipeline-timeout'
190190
command:
@@ -197,7 +197,7 @@ services:
197197
extra_hosts:
198198
- "host.docker.internal:host-gateway"
199199

200-
timeout-closing:
200+
timeout-task-closing:
201201
<<: *base-service
202202
container_name: 'kernelci-pipeline-closing'
203203
command:
@@ -210,7 +210,7 @@ services:
210210
extra_hosts:
211211
- "host.docker.internal:host-gateway"
212212

213-
timeout-holdoff:
213+
timeout-task-holdoff:
214214
<<: *base-service
215215
container_name: 'kernelci-pipeline-holdoff'
216216
command:

kube/aks/nodehandlers.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ spec:
2020
app: timeout
2121
spec:
2222
containers:
23-
- name: timeout
23+
- name: timeout-task
2424
image: kernelci/kernelci:pipeline@sha256:bb01424c4dedcd2ffa87cef225b09116cf874bc2b91fc63ed6d993d6fc5c43cb
2525
imagePullPolicy: Always
2626
command:
@@ -68,7 +68,7 @@ spec:
6868
app: closing
6969
spec:
7070
containers:
71-
- name: timeout
71+
- name: timeout-task
7272
image: kernelci/kernelci:pipeline@sha256:bb01424c4dedcd2ffa87cef225b09116cf874bc2b91fc63ed6d993d6fc5c43cb
7373
imagePullPolicy: Always
7474
command:
@@ -112,7 +112,7 @@ spec:
112112
app: holdoff
113113
spec:
114114
containers:
115-
- name: timeout
115+
- name: timeout-task
116116
image: kernelci/kernelci:pipeline@sha256:bb01424c4dedcd2ffa87cef225b09116cf874bc2b91fc63ed6d993d6fc5c43cb
117117
imagePullPolicy: Always
118118
command:

kube/minikube/deployments/timeout-closing-deployment.yaml

+4-4
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,19 @@
66
apiVersion: apps/v1
77
kind: Deployment
88
metadata:
9-
name: kernelci-pipeline-timeout-closing
9+
name: kernelci-pipeline-timeout-task-closing
1010
spec:
1111
replicas: 1
1212
selector:
1313
matchLabels:
14-
app: kernelci-pipeline-timeout-closing
14+
app: kernelci-pipeline-timeout-task-closing
1515
template:
1616
metadata:
1717
labels:
18-
app: kernelci-pipeline-timeout-closing
18+
app: kernelci-pipeline-timeout-task-closing
1919
spec:
2020
containers:
21-
- name: kernelci-pipeline-timeout-closing
21+
- name: kernelci-pipeline-timeout-task-closing
2222
image: kernelci/staging-kernelci
2323
env:
2424
- name: KCI_API_TOKEN

kube/minikube/deployments/timeout-holdoff-deployment.yaml

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
apiVersion: apps/v1
22
kind: Deployment
33
metadata:
4-
name: kernelci-pipeline-timeout-holdoff
4+
name: kernelci-pipeline-timeout-task-holdoff
55
spec:
66
replicas: 1
77
selector:
88
matchLabels:
9-
app: kernelci-pipeline-timeout-holdoff
9+
app: kernelci-pipeline-timeout-task-holdoff
1010
template:
1111
metadata:
1212
labels:
13-
app: kernelci-pipeline-timeout-holdoff
13+
app: kernelci-pipeline-timeout-task-holdoff
1414
spec:
1515
containers:
16-
- name: kernelci-pipeline-timeout-holdoff
16+
- name: kernelci-pipeline-timeout-task-holdoff
1717
image: kernelci/staging-kernelci
1818
env:
1919
- name: KCI_API_TOKEN

src/timeout.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ def _submit_lapsed_nodes(self, lapsed_nodes, state, mode):
105105
class Timeout(TimeoutService):
106106

107107
def __init__(self, configs, args):
108-
super().__init__(configs, args, 'timeout')
108+
super().__init__(configs, args, 'timeout-task')
109109

110110
def _check_pending_nodes(self, pending_nodes):
111111
timeout_nodes = {}
@@ -132,7 +132,7 @@ def _run(self, ctx):
132132
class Holdoff(TimeoutService):
133133

134134
def __init__(self, configs, args):
135-
super().__init__(configs, args, 'timeout-holdoff')
135+
super().__init__(configs, args, 'timeout-task-holdoff')
136136

137137
def _get_available_nodes(self):
138138
nodes = self._api.node.find({
@@ -177,7 +177,7 @@ def _run(self, ctx):
177177
class Closing(TimeoutService):
178178

179179
def __init__(self, configs, args):
180-
super().__init__(configs, args, 'timeout-closing')
180+
super().__init__(configs, args, 'timeout-task-closing')
181181

182182
def _get_closing_nodes(self):
183183
nodes = self._api.node.find({'state': 'closing'})

0 commit comments

Comments
 (0)