You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Guys, the most important events of both this protocol and Kernel protocol (including this here as there doesn't seem to be a git repository) are unusable:
Both deposit and redeem don't include which token was actually depositted/redeemed, to its balance can't be tracked. Sure, one could track Transfer events, but this is a) stupid when there are already more specific events and b) can't cope with "donations".
Kernel protocol TokenAdded event is sent after CapIncrease. Its possible to deal with this, but well, it could also be done right.
As these contracts are already deployed, the damage is one, but just in case you are at some point deploying a third protocol, please make sure the events are coherent and include all necessary information.
Also both contracts unnecessarily waste a lot of gas by reading global variables again and again instead of using the common scheme of using a local copy and reading just once. Same here, please make sure you at least get it right next time.
The text was updated successfully, but these errors were encountered:
Guys, the most important events of both this protocol and Kernel protocol (including this here as there doesn't seem to be a git repository) are unusable:
Both deposit and redeem don't include which token was actually depositted/redeemed, to its balance can't be tracked. Sure, one could track Transfer events, but this is a) stupid when there are already more specific events and b) can't cope with "donations".
Kernel protocol TokenAdded event is sent after CapIncrease. Its possible to deal with this, but well, it could also be done right.
As these contracts are already deployed, the damage is one, but just in case you are at some point deploying a third protocol, please make sure the events are coherent and include all necessary information.
Also both contracts unnecessarily waste a lot of gas by reading global variables again and again instead of using the common scheme of using a local copy and reading just once. Same here, please make sure you at least get it right next time.
The text was updated successfully, but these errors were encountered: