Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events unusable #1

Open
kaber2 opened this issue Jul 12, 2024 · 0 comments
Open

Events unusable #1

kaber2 opened this issue Jul 12, 2024 · 0 comments

Comments

@kaber2
Copy link

kaber2 commented Jul 12, 2024

Guys, the most important events of both this protocol and Kernel protocol (including this here as there doesn't seem to be a git repository) are unusable:

  • Both deposit and redeem don't include which token was actually depositted/redeemed, to its balance can't be tracked. Sure, one could track Transfer events, but this is a) stupid when there are already more specific events and b) can't cope with "donations".

  • Kernel protocol TokenAdded event is sent after CapIncrease. Its possible to deal with this, but well, it could also be done right.

As these contracts are already deployed, the damage is one, but just in case you are at some point deploying a third protocol, please make sure the events are coherent and include all necessary information.

Also both contracts unnecessarily waste a lot of gas by reading global variables again and again instead of using the common scheme of using a local copy and reading just once. Same here, please make sure you at least get it right next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant