Skip to content

Commit f8b5d42

Browse files
orionrezyang
authored andcommitted
Fix Caffe2 build with ATen CPU/GPU split (pytorch#7486)
1 parent 75f549b commit f8b5d42

File tree

4 files changed

+14
-7
lines changed

4 files changed

+14
-7
lines changed

aten/CMakeLists.txt

+6-1
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,12 @@ ${CMAKE_CURRENT_BINARY_DIR}/src/ATen)
544544
if(NOT NO_CUDA)
545545
include_directories(${CUDA_INCLUDE_DIRS})
546546
endif()
547-
add_subdirectory(src/ATen/test)
547+
548+
if(ATEN_NO_TEST)
549+
message("disable test because ATEN_NO_TEST is set")
550+
else()
551+
add_subdirectory(src/ATen/test)
552+
endif()
548553

549554
if(ATEN_NO_CONTRIB)
550555
message("disable contrib because ATEN_NO_CONTRIB is set")

caffe2/CMakeLists.txt

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ if(BUILD_ATEN)
1414
if(NOT BUILD_CAFFE2)
1515
set(__caffe2_CMAKE_POSITION_INDEPENDENT_CODE ${CMAKE_POSITION_INDEPENDENT_CODE})
1616
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
17+
set(ATEN_NO_TEST ON)
1718
set(AT_LINK_STYLE STATIC)
1819
add_subdirectory(../aten aten)
1920
set(CMAKE_POSITION_INDEPENDENT_CODE ${__caffe2_CMAKE_POSITION_INDEPENDENT_CODE})

caffe2/contrib/aten/CMakeLists.txt

+5-4
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,18 @@ if(BUILD_ATEN)
33
# Unfortunately the custom command below requires this to be here
44
set(__caffe2_CMAKE_POSITION_INDEPENDENT_CODE ${CMAKE_POSITION_INDEPENDENT_CODE})
55
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
6+
set(ATEN_NO_TEST ON)
67
set(AT_LINK_STYLE STATIC)
7-
add_subdirectory(${PROJECT_SOURCE_DIR}/aten aten)
8+
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/../../../aten aten)
89
set(CMAKE_POSITION_INDEPENDENT_CODE ${__caffe2_CMAKE_POSITION_INDEPENDENT_CODE})
910

1011
add_custom_command(OUTPUT aten_op.h
1112
COMMAND
1213
python ${CMAKE_CURRENT_SOURCE_DIR}/gen_op.py
13-
--aten_root=${PROJECT_SOURCE_DIR}/aten
14-
--template_dir=${PROJECT_SOURCE_DIR}/caffe2/contrib/aten
14+
--aten_root=${CMAKE_CURRENT_SOURCE_DIR}/../../../aten
15+
--template_dir=${CMAKE_CURRENT_SOURCE_DIR}
1516
DEPENDS
16-
ATen
17+
ATen_cpu
1718
${CMAKE_CURRENT_SOURCE_DIR}/gen_op.py
1819
${CMAKE_CURRENT_SOURCE_DIR}/aten_op_template.h)
1920

cmake/Dependencies.cmake

+2-2
Original file line numberDiff line numberDiff line change
@@ -579,9 +579,9 @@ if (BUILD_ATEN)
579579
include_directories(${PROJECT_BINARY_DIR}/caffe2/contrib/aten)
580580
endif()
581581

582-
list(APPEND Caffe2_DEPENDENCY_LIBS ATen)
582+
list(APPEND Caffe2_DEPENDENCY_LIBS ATen_cpu)
583583
if (USE_CUDA)
584-
list(APPEND Caffe2_CUDA_DEPENDENCY_LIBS ATen)
584+
list(APPEND Caffe2_CUDA_DEPENDENCY_LIBS ATen_cuda)
585585
endif()
586586
include_directories(${PROJECT_SOURCE_DIR}/aten/src)
587587
endif()

0 commit comments

Comments
 (0)