feat: provide error response that a block has already been deleted

This checks to see if the block is alive or not before doing a delete on
it. This makes it so we can at least tell the block is in the trash (as
we don't do permanent deletes).

Author: kevinjalbert

shared/notionscripts/already_deleted_error.py

@@ -0,0 +1,6 @@
+#!/usr/bin/env -S PATH="${PATH}:/usr/local/bin" python3
+
+
+class AlreadyDeletedError(Exception):
+    def __init__(self, block_id):
+        super().__init__(f"Block {block_id} has already been deleted")

shared/notionscripts/notion_api.py

@@ -1,5 +1,6 @@
 #!/usr/bin/env -S PATH="${PATH}:/usr/local/bin" python3
 from notionscripts.block_presenter import BlockPresenter
+from notionscripts.already_deleted_error import AlreadyDeletedError
 
 from cachetools import cached
 
@@ -47,9 +48,11 @@ def block_update(self, block_id, data):
     def block_delete(self, block_id):
         block = self.client().get_block(block_id)
 
-        block.remove()
-
-        return BlockPresenter(block)
+        if block.alive:
+            block.remove()
+            return BlockPresenter(block)
+        else:
+            raise AlreadyDeletedError(block_id)
 
     def collection_view_content(self, collection_id, view_id):
         collection_view = self.__collection_view(collection_id, view_id)

shared/notionscripts/tests/test_notion_api.py

@@ -1,4 +1,5 @@
 from notionscripts.notion_api import NotionApi
+from notionscripts.already_deleted_error import AlreadyDeletedError
 
 from .notion_api_page_helper import get_test_page, create_collection_view
 
@@ -87,6 +88,20 @@ def test_block_delete_with_collection_block(notion_token):
     assert block not in collection_view.collection.get_rows()
 
 
+def test_block_delete_an_already_deleted_block(notion_token):
+    notion_api = NotionApi(token=notion_token)
+    test_page = get_test_page()
+
+    block = test_page.children.add_new(TextBlock, title="test block delete")
+    parent_block = block.parent
+
+    notion_api.block_delete(block.id)
+    parent_block.refresh()
+
+    with pytest.raises(AlreadyDeletedError):
+        notion_api.block_delete(block.id)
+
+
 def test_collection_view_content(notion_token):
     notion_api = NotionApi(token=notion_token)