Bug: remove old conditional in ClusterExtension (operator-framework#1089)

trgeiger · Per Goncalves da Silva · commit b9f7d24f953a · 2024-08-13T11:14:27.000-03:00
Removes old conditional for handling ErrReleaseNotFound
which was preventing the new logic from firing.

Signed-off-by: Tayler Geiger &lt;tayler@redhat.com&gt;
diff --git a/internal/controllers/clusterextension_controller.go b/internal/controllers/clusterextension_controller.go
@@ -553,9 +553,6 @@ func (r *ClusterExtensionReconciler) getReleaseState(cl helmclient.ActionInterfa
 	if err != nil && !errors.Is(err, driver.ErrReleaseNotFound) {
 		return nil, nil, stateError, err
 	}
-	if errors.Is(err, driver.ErrReleaseNotFound) {
-		return nil, nil, stateNeedsInstall, nil
-	}
 
 	if errors.Is(err, driver.ErrReleaseNotFound) {
 		desiredRelease, err := cl.Install(ext.GetName(), ext.Spec.InstallNamespace, chrt, values, func(i *action.Install) error {

Original file line number	Diff line number	Diff line change
`@@ -553,9 +553,6 @@ func (r *ClusterExtensionReconciler) getReleaseState(cl helmclient.ActionInterfa`
`553`	`553`	`if err != nil && !errors.Is(err, driver.ErrReleaseNotFound) {`
`554`	`554`	`return nil, nil, stateError, err`
`555`	`555`	`}`
`556`		`- if errors.Is(err, driver.ErrReleaseNotFound) {`
`557`		`- return nil, nil, stateNeedsInstall, nil`
`558`		`- }`
`559`	`556`
`560`	`557`	`if errors.Is(err, driver.ErrReleaseNotFound) {`
`561`	`558`	`desiredRelease, err := cl.Install(ext.GetName(), ext.Spec.InstallNamespace, chrt, values, func(i *action.Install) error {`