Improve exception handling in Guacamole view & Vpshere (#2655)

Kyrd0x · web-flow · commit c7d380993325 · 2025-07-28T22:15:10.000+02:00
* Improve exception handling in Guacamole view &amp; Vpshere exception
diff --git a/modules/machinery/vsphere.py b/modules/machinery/vsphere.py
@@ -113,8 +113,9 @@ def _initialize_check(self):
                         raise CuckooCriticalError(
                             f"Snapshot for machine {machine.label} not in powered-on state, please create one"
                         )
-        except Exception:
-            raise CuckooCriticalError("Couldn't connect to vSphere host")
+        except Exception as e:
+            logging.exception("Couldn't connect to vSphere host")
+            raise CuckooCriticalError(f"Couldn't connect to vSphere host: {e}")
 
         super(vSphere, self)._initialize_check()
 
diff --git a/web/guac/templates/guac/error.html b/web/guac/templates/guac/error.html
@@ -1,3 +1,4 @@
+{% load static %}
 <!DOCTYPE html>
 <html>
 <head>
diff --git a/web/guac/views.py b/web/guac/views.py
@@ -1,22 +1,41 @@
 from base64 import urlsafe_b64decode
 from xml.etree import ElementTree as ET
-
 from django.shortcuts import render
-
 from lib.cuckoo.common.config import Config
 
 try:
     import libvirt
+
+    LIBVIRT_AVAILABLE = True
 except ImportError:
     print("Missed python-libvirt. Use extra/libvirt_installer.sh")
+    LIBVIRT_AVAILABLE = False
 
 machinery = Config().cuckoo.machinery
+machinery_available = ["kvm", "qemu"]
 machinery_dsn = getattr(Config(machinery), machinery).get("dsn", "qemu:///system")
 
 
 def index(request, task_id, session_data):
-    conn = libvirt.open(machinery_dsn)
+    if not LIBVIRT_AVAILABLE:
+        return render(
+            request,
+            "guac/error.html",
+            {"error_msg": "Libvirt not available", "error": "remote session", "task_id": task_id},
+        )
+
+    if machinery not in machinery_available:
+        return render(
+            request,
+            "guac/error.html",
+            {"error_msg": f"Machinery type '{machinery}' is not supported", "error": "remote session", "task_id": task_id},
+        )
+
+    conn = None
+    state = None
     recording_name = ""
+
+    conn = libvirt.open(machinery_dsn)
     if conn:
         try:
             session_id, label, guest_ip = urlsafe_b64decode(session_data).decode("utf8").split("|")

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+{% load static %}`
`1`	`2`	`<!DOCTYPE html>`
`2`	`3`	`<html>`
`3`	`4`	`<head>`