-
Notifications
You must be signed in to change notification settings - Fork 85
Open
Labels
Description
Two comments that are not urgent (so merge if you want):
Several member getters could return aconstobject (for examplePhi()orphi()returning adoubleinstead of aconst double- There are two members that could by statically allocated in
GridDRcalo_k4geo.cpp, then the destructor doesn't need to be defined:k4geo/detectorSegmentations/src/GridDRcalo_k4geo.cpp
Lines 26 to 27 in 550e75e
fParamBarrel = new DRparamBarrel_k4geo(); fParamEndcap = new DRparamEndcap_k4geo();
Originally posted by @jmcarcell in #517 (review)
Reactions are currently unavailable