Skip to content

The single-field class formatter should support standard Play format #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
evictor opened this issue Nov 7, 2014 · 6 comments
Closed

Comments

@evictor
Copy link

evictor commented Nov 7, 2014

We would love to use your plugin at Gravity, but unfortunately it would require a difficult migration for certain single-value case classes that use the standard Play format (e.g. {"name":"Bob"} for case class Person(name: String)). The problem is that we have many such classes and serializations being stored and transmitted among many apps; to use your plugin as-is we would have to perform a difficult migration involving hundreds of servers.

Would it be possible for you to release a patch to support "backwards compatibility" with the default Play format for single-value case classes? If not, I suppose I could do my best to submit a PR with one, but chances are you'll be able to whip that out much more quickly as I have no macro experience...

@erraggy
Copy link

erraggy commented Nov 7, 2014

+1

3 similar comments
@hindog
Copy link

hindog commented Nov 7, 2014

+1

@adriangrealish
Copy link

+1

@TreyThree
Copy link

+1

@stkem
Copy link
Contributor

stkem commented Nov 7, 2014

#5

@stkem stkem closed this as completed Nov 7, 2014
@evictor
Copy link
Author

evictor commented Nov 8, 2014

👍 :)

mslinn pushed a commit to mslinn/json-annotation that referenced this issue Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants