Skip to content

Commit 298be81

Browse files
committed
fix: changes after self review
1 parent 8607762 commit 298be81

File tree

5 files changed

+3
-13
lines changed

5 files changed

+3
-13
lines changed

FabricExample/src/screens/Examples/KeyboardExtender/index.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@ import Reanimated, {
1717
} from "react-native-reanimated";
1818
import { SafeAreaView } from "react-native-safe-area-context";
1919

20-
// TODO: remove _touchHandler when view gets detached from keyboard?
21-
// TODO: test how GestureHandler works there
22-
// TODO: don't overwrite existing inputAccessoryView?
23-
2420
export default function KeyboardExtendExample() {
2521
const [showExtend, setShowExtend] = useState(true);
2622
const opacity = useSharedValue(1);

example/src/screens/Examples/KeyboardExtender/index.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@ import Reanimated, {
1717
} from "react-native-reanimated";
1818
import { SafeAreaView } from "react-native-safe-area-context";
1919

20-
// TODO: remove _touchHandler when view gets detached from keyboard?
21-
// TODO: test how GestureHandler works there
22-
// TODO: don't overwrite existing inputAccessoryView?
23-
2420
export default function KeyboardExtendExample() {
2521
const [showExtend, setShowExtend] = useState(true);
2622
const opacity = useSharedValue(1);

ios/views/KeyboardExtenderManager.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
// KeyboardExtenderManager.h
33
// KeyboardController
44
//
5-
// Created by Kiryl Ziusko on 17.09.24.
6-
// Copyright © 2024 Facebook. All rights reserved.
5+
// Created by Kiryl Ziusko on 13.04.25.
6+
// Copyright © 2025 Facebook. All rights reserved.
77
//
88
#ifdef RCT_NEW_ARCH_ENABLED
99
#import <React/RCTViewComponentView.h>

ios/views/KeyboardExtenderManager.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// KeyboardExtenderManager.mm
33
// react-native-keyboard-controller
44
//
5-
// Created by Kiryl Ziusko on 11/09/2024.
5+
// Created by Kiryl Ziusko on 13/04/2025.
66
//
77

88
#import "KeyboardExtenderManager.h"

src/views/KeyboardExtender/index.ios.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import { useWindowDimensions } from "../../hooks";
77
import type { KeyboardExtenderProps } from "../../types";
88
import type { PropsWithChildren } from "react";
99

10-
// TODO: e2e tests with dark UI? force keyboardAppearance or change system UI?
11-
1210
/**
1311
* A component that embeds its children into the keyboard thus enhancing keyboard functionality.
1412
*

0 commit comments

Comments
 (0)