Skip to content

Commit 49898cd

Browse files
kirillzyuskokirillzyusko
authored
ci: use newer XCode (#964)
## 📜 Description In preparation for actions/runner-images#12195 ## 💡 Motivation and Context XCode 15.4 will be removed soon (and in fact it's already removed on some nodes and because of this some jobs may fail). To fix this I locked XCode version to `16.2` (I also use locally this version). ## 📢 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### CI - use `XCode 16.2` version for CI jobs; - lock iOS version for iOS performance tests; - update `destination` for iOS builds (to iPhone 16 Pro); - create performance baseline for iPhone 16 Pro, iOS 18.4. ## 🤔 How Has This Been Tested? Tested via this PR. ## 📸 Screenshots (if appropriate): <!-- Add screenshots/video if needed --> <!-- That would be highly appreciated if you can add how it looked before and after your changes --> ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
1 parent 76226df commit 49898cd

File tree

6 files changed

+177
-7
lines changed

6 files changed

+177
-7
lines changed

‎.github/workflows/build-ios-fabric.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838

3939
- uses: maxim-lobanov/setup-xcode@v1
4040
with:
41-
xcode-version: "15.4"
41+
xcode-version: "16.2"
4242

4343
- name: Get yarn cache directory path
4444
id: fabric-yarn-cache-dir-path
@@ -98,6 +98,6 @@ jobs:
9898
-scheme KeyboardControllerFabricExample \
9999
-sdk iphonesimulator \
100100
-configuration Debug \
101-
-destination 'platform=iOS Simulator,name=iPhone 11 Pro' \
101+
-destination 'platform=iOS Simulator,name=iPhone 16 Pro' \
102102
build \
103103
CODE_SIGNING_ALLOWED=NO | xcpretty"

‎.github/workflows/build-ios.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636

3737
- uses: maxim-lobanov/setup-xcode@v1
3838
with:
39-
xcode-version: "15.4"
39+
xcode-version: "16.2"
4040

4141
- name: Get yarn cache directory path
4242
id: yarn-cache-dir-path
@@ -96,6 +96,6 @@ jobs:
9696
-scheme KeyboardControllerExample \
9797
-sdk iphonesimulator \
9898
-configuration Debug \
99-
-destination 'platform=iOS Simulator,name=iPhone 11 Pro' \
99+
-destination 'platform=iOS Simulator,name=iPhone 16 Pro' \
100100
build \
101101
CODE_SIGNING_ALLOWED=NO | xcpretty"

‎.github/workflows/ios-e2e-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
cache: "yarn"
4040
- uses: maxim-lobanov/setup-xcode@v1
4141
with:
42-
xcode-version: "15.4"
42+
xcode-version: "16.2"
4343
- name: Get Xcode version
4444
run: xcodebuild -version
4545
- name: Save yarn cache directory path

‎.github/workflows/verify-ios.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565

6666
- uses: maxim-lobanov/setup-xcode@v1
6767
with:
68-
xcode-version: "15.4"
68+
xcode-version: "16.2"
6969

7070
- name: Install xcpretty
7171
run: gem install xcpretty
@@ -75,5 +75,5 @@ jobs:
7575
test \
7676
-scheme KeyboardControllerNative \
7777
-only-testing KeyboardControllerNativeTests \
78-
-destination 'platform=iOS Simulator,name=iPhone 15 Pro' \
78+
-destination 'platform=iOS Simulator,name=iPhone 16 Pro,OS=18.4' \
7979
CODE_SIGNING_ALLOWED=NO | xcpretty"

‎ios/KeyboardControllerNative/KeyboardControllerNative.xcodeproj/xcshareddata/xcbaselines/0873ED612BB6B7390004F3A4.xcbaseline/D5199330-AFF6-4C67-A368-DA66545865D7.plist

Lines changed: 139 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,139 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
3+
<plist version="1.0">
4+
<dict>
5+
<key>classNames</key>
6+
<dict>
7+
<key>SpringAnimationPerformanceTest</key>
8+
<dict>
9+
<key>testCriticallyDampedTimingAtPerformance()</key>
10+
<dict>
11+
<key>com.apple.dt.XCTMetric_CPU.cycles</key>
12+
<dict>
13+
<key>baselineAverage</key>
14+
<real>499915.169100</real>
15+
<key>baselineIntegrationDisplayName</key>
16+
<string>Local Baseline</string>
17+
</dict>
18+
<key>com.apple.dt.XCTMetric_CPU.instructions_retired</key>
19+
<dict>
20+
<key>baselineAverage</key>
21+
<real>1626009.767700</real>
22+
<key>baselineIntegrationDisplayName</key>
23+
<string>Local Baseline</string>
24+
</dict>
25+
<key>com.apple.dt.XCTMetric_CPU.time</key>
26+
<dict>
27+
<key>baselineAverage</key>
28+
<real>0.161917</real>
29+
<key>baselineIntegrationDisplayName</key>
30+
<string>Local Baseline</string>
31+
</dict>
32+
<key>com.apple.dt.XCTMetric_Clock.time.monotonic</key>
33+
<dict>
34+
<key>baselineAverage</key>
35+
<real>0.161384</real>
36+
<key>baselineIntegrationDisplayName</key>
37+
<string>Local Baseline</string>
38+
</dict>
39+
</dict>
40+
<key>testCriticallyDampedValueAtPerformance()</key>
41+
<dict>
42+
<key>com.apple.dt.XCTMetric_CPU.cycles</key>
43+
<dict>
44+
<key>baselineAverage</key>
45+
<real>10075.142300</real>
46+
<key>baselineIntegrationDisplayName</key>
47+
<string>Local Baseline</string>
48+
</dict>
49+
<key>com.apple.dt.XCTMetric_CPU.instructions_retired</key>
50+
<dict>
51+
<key>baselineAverage</key>
52+
<real>44786.401800</real>
53+
<key>baselineIntegrationDisplayName</key>
54+
<string>Local Baseline</string>
55+
</dict>
56+
<key>com.apple.dt.XCTMetric_CPU.time</key>
57+
<dict>
58+
<key>baselineAverage</key>
59+
<real>0.003278</real>
60+
<key>baselineIntegrationDisplayName</key>
61+
<string>Local Baseline</string>
62+
</dict>
63+
<key>com.apple.dt.XCTMetric_Clock.time.monotonic</key>
64+
<dict>
65+
<key>baselineAverage</key>
66+
<real>0.002818</real>
67+
<key>baselineIntegrationDisplayName</key>
68+
<string>Local Baseline</string>
69+
</dict>
70+
</dict>
71+
</dict>
72+
<key>TimingAnimationPerformanceTest</key>
73+
<dict>
74+
<key>testTimingAtPerformance()</key>
75+
<dict>
76+
<key>com.apple.dt.XCTMetric_CPU.cycles</key>
77+
<dict>
78+
<key>baselineAverage</key>
79+
<real>558312.332900</real>
80+
<key>baselineIntegrationDisplayName</key>
81+
<string>Local Baseline</string>
82+
</dict>
83+
<key>com.apple.dt.XCTMetric_CPU.instructions_retired</key>
84+
<dict>
85+
<key>baselineAverage</key>
86+
<real>2279017.116100</real>
87+
<key>baselineIntegrationDisplayName</key>
88+
<string>Local Baseline</string>
89+
</dict>
90+
<key>com.apple.dt.XCTMetric_CPU.time</key>
91+
<dict>
92+
<key>baselineAverage</key>
93+
<real>0.180904</real>
94+
<key>baselineIntegrationDisplayName</key>
95+
<string>Local Baseline</string>
96+
</dict>
97+
<key>com.apple.dt.XCTMetric_Clock.time.monotonic</key>
98+
<dict>
99+
<key>baselineAverage</key>
100+
<real>0.180440</real>
101+
<key>baselineIntegrationDisplayName</key>
102+
<string>Local Baseline</string>
103+
</dict>
104+
</dict>
105+
<key>testValueAtPerformance()</key>
106+
<dict>
107+
<key>com.apple.dt.XCTMetric_CPU.cycles</key>
108+
<dict>
109+
<key>baselineAverage</key>
110+
<real>231132.343700</real>
111+
<key>baselineIntegrationDisplayName</key>
112+
<string>Local Baseline</string>
113+
</dict>
114+
<key>com.apple.dt.XCTMetric_CPU.instructions_retired</key>
115+
<dict>
116+
<key>baselineAverage</key>
117+
<real>946012.667800</real>
118+
<key>baselineIntegrationDisplayName</key>
119+
<string>Local Baseline</string>
120+
</dict>
121+
<key>com.apple.dt.XCTMetric_CPU.time</key>
122+
<dict>
123+
<key>baselineAverage</key>
124+
<real>0.072835</real>
125+
<key>baselineIntegrationDisplayName</key>
126+
<string>Local Baseline</string>
127+
</dict>
128+
<key>com.apple.dt.XCTMetric_Clock.time.monotonic</key>
129+
<dict>
130+
<key>baselineAverage</key>
131+
<real>0.075363</real>
132+
<key>baselineIntegrationDisplayName</key>
133+
<string>Local Baseline</string>
134+
</dict>
135+
</dict>
136+
</dict>
137+
</dict>
138+
</dict>
139+
</plist>

‎ios/KeyboardControllerNative/KeyboardControllerNative.xcodeproj/xcshareddata/xcbaselines/0873ED612BB6B7390004F3A4.xcbaseline/Info.plist

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,37 @@
3535
<string>com.apple.platform.iphonesimulator</string>
3636
</dict>
3737
</dict>
38+
<key>D5199330-AFF6-4C67-A368-DA66545865D7</key>
39+
<dict>
40+
<key>localComputer</key>
41+
<dict>
42+
<key>busSpeedInMHz</key>
43+
<integer>0</integer>
44+
<key>cpuCount</key>
45+
<integer>1</integer>
46+
<key>cpuKind</key>
47+
<string>Apple M1 Pro</string>
48+
<key>cpuSpeedInMHz</key>
49+
<integer>0</integer>
50+
<key>logicalCPUCoresPerPackage</key>
51+
<integer>10</integer>
52+
<key>modelCode</key>
53+
<string>MacBookPro18,1</string>
54+
<key>physicalCPUCoresPerPackage</key>
55+
<integer>10</integer>
56+
<key>platformIdentifier</key>
57+
<string>com.apple.platform.macosx</string>
58+
</dict>
59+
<key>targetArchitecture</key>
60+
<string>arm64</string>
61+
<key>targetDevice</key>
62+
<dict>
63+
<key>modelCode</key>
64+
<string>iPhone17,1</string>
65+
<key>platformIdentifier</key>
66+
<string>com.apple.platform.iphonesimulator</string>
67+
</dict>
68+
</dict>
3869
</dict>
3970
</dict>
4071
</plist>

0 commit comments

Comments
 (0)