remove workflow and saga state comments

Author: kivo2

common/src/main/java/com/example/common/enums/SagaStep.java

@@ -10,7 +10,7 @@ public enum SagaStep {
   COMPLETED,
   FAILED,
 
-  // Compensating steps (Phase 4)
+  // Compensating steps
   RELEASE_INVENTORY,
   REFUND_PAYMENT,
   CANCEL_ORDER

orchestrator/src/main/java/com/example/orchestrator/messaging/KafkaConsumerConfig.java

@@ -17,15 +17,6 @@
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
 
-/**
- * Kafka consumer configuration for orchestrator.
- *
- * <p>Orchestrator consumes worker events (inventory.events, payment.events, order.events) to
- * advance saga state.
- *
- * <p>Consumer group: orchestrator-group Acknowledgment mode: MANUAL (commit after successful
- * processing) Concurrency: 1 per topic (can increase for higher throughput)
- */
 @Configuration
 public class KafkaConsumerConfig {
 

orchestrator/src/main/java/com/example/orchestrator/service/CheckoutOrchestrator.java

@@ -36,12 +36,10 @@ public class CheckoutOrchestrator {
 
   @Transactional
   public UUID startCheckout(StartCheckoutRequest request) {
-    // Create saga in STARTED state
     Saga saga = sagaStateService.createSaga(request.getCustomerId(), maxRetries);
     log.info(
         "[saga={}] Checkout started for customer={}", saga.getSagaId(), request.getCustomerId());
 
-    // Store original request payload as JSON for future steps
     try {
       String requestJson = objectMapper.writeValueAsString(request);
       saga.setRequestPayload(requestJson);
@@ -54,22 +52,16 @@ public UUID startCheckout(StartCheckoutRequest request) {
           "Failed to serialize request payload for saga=" + saga.getSagaId(), e);
     }
 
-    // Publish RESERVE_INVENTORY command
     publishCommand(saga.getSagaId(), CommandType.RESERVE_INVENTORY, request);
 
     return saga.getSagaId();
   }
 
-  /** Get the current state of a saga. */
   @Transactional(readOnly = true)
   public Saga getStatus(UUID sagaId) {
     return sagaRepository.findById(sagaId).orElseThrow(() -> new SagaNotFoundException(sagaId));
   }
 
-  /**
-   * Handle InventoryReservedEvent from inventory.events topic. Advance saga to AUTHORIZE_PAYMENT
-   * and publish payment command.
-   */
   @Transactional
   public void handleInventoryReserved(UUID sagaId, UUID reservationId) {
     log.info(
@@ -80,7 +72,6 @@ public void handleInventoryReserved(UUID sagaId, UUID reservationId) {
     Saga saga =
         sagaRepository.findById(sagaId).orElseThrow(() -> new SagaNotFoundException(sagaId));
 
-    // Idempotency check: only process if still on RESERVE_INVENTORY step
     if (saga.getCurrentStep() != SagaStep.RESERVE_INVENTORY) {
       log.info(
           "[saga={}] Already past step {}, skipping (idempotency)",
@@ -89,18 +80,12 @@ public void handleInventoryReserved(UUID sagaId, UUID reservationId) {
       return;
     }
 
-    // Advance saga state
     sagaStateService.advanceStep(sagaId, SagaStep.AUTHORIZE_PAYMENT);
 
-    // Publish AUTHORIZE_PAYMENT command (need to reconstruct request - stored in saga or outbox)
     StartCheckoutRequest request = buildRequestFromSaga(saga);
     publishCommand(sagaId, CommandType.AUTHORIZE_PAYMENT, request);
   }
 
-  /**
-   * Handle PaymentAuthorizedEvent from payment.events topic. Advance saga to CREATE_ORDER and
-   * publish order command.
-   */
   @Transactional
   public void handlePaymentAuthorized(UUID sagaId, UUID paymentId) {
     log.info(
@@ -109,7 +94,6 @@ public void handlePaymentAuthorized(UUID sagaId, UUID paymentId) {
     Saga saga =
         sagaRepository.findById(sagaId).orElseThrow(() -> new SagaNotFoundException(sagaId));
 
-    // Idempotency check: only process if still on AUTHORIZE_PAYMENT step
     if (saga.getCurrentStep() != SagaStep.AUTHORIZE_PAYMENT) {
       log.info(
           "[saga={}] Already past step {}, skipping (idempotency)",
@@ -118,35 +102,29 @@ public void handlePaymentAuthorized(UUID sagaId, UUID paymentId) {
       return;
     }
 
-    // Record payment ID
     sagaStateService.recordPayment(sagaId, paymentId);
     sagaStateService.advanceStep(sagaId, SagaStep.CREATE_ORDER);
 
-    // Publish CREATE_ORDER command
     StartCheckoutRequest request = buildRequestFromSaga(saga);
     publishCommand(sagaId, CommandType.CREATE_ORDER, request);
   }
 
-  /** Handle OrderCreatedEvent from order.events topic. Mark saga as COMPLETED. */
   @Transactional
   public void handleOrderCreated(UUID sagaId, UUID orderId) {
     log.info("[saga={}] Order created orderId={}, marking COMPLETED", sagaId, orderId);
 
     Saga saga =
         sagaRepository.findById(sagaId).orElseThrow(() -> new SagaNotFoundException(sagaId));
 
-    // Idempotency check: only process if still on CREATE_ORDER step
     if (saga.getCurrentStep() != SagaStep.CREATE_ORDER) {
       log.info(
           "[saga={}] Already past step {}, skipping (idempotency)", sagaId, SagaStep.CREATE_ORDER);
       return;
     }
 
-    // Mark saga completed
     sagaStateService.completeSaga(sagaId, orderId);
   }
 
-  /** Publish a command to checkout.commands topic with sagaId as partition key. */
   private void publishCommand(UUID sagaId, CommandType commandType, StartCheckoutRequest request) {
     CheckoutCommand command = new CheckoutCommand();
     command.setSagaId(sagaId);
@@ -171,12 +149,6 @@ private void publishCommand(UUID sagaId, CommandType commandType, StartCheckoutR
     }
   }
 
-  /**
-   * Reconstruct StartCheckoutRequest from saga state.
-   *
-   * <p>Deserializes the original request from saga.requestPayload. Falls back to hardcoded test
-   * data if payload is missing (for backwards compatibility with old sagas).
-   */
   private StartCheckoutRequest buildRequestFromSaga(Saga saga) {
     // Try to deserialize from stored payload
     if (saga.getRequestPayload() != null) {
@@ -194,7 +166,6 @@ private StartCheckoutRequest buildRequestFromSaga(Saga saga) {
           saga.getSagaId());
     }
 
-    // FALLBACK: Use hardcoded test data (for backwards compatibility)
     StartCheckoutRequest request = new StartCheckoutRequest();
     request.setCustomerId(saga.getCustomerId());
 

order-worker/src/main/java/com/example/order/service/OrderService.java

@@ -16,15 +16,6 @@
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 
-/**
- * Real order creation logic.
- *
- * <p>IDEMPOTENCY: If an order already exists for this sagaId, return the existing orderId without
- * creating a duplicate record.
- *
- * <p>FAILURE SCENARIOS: customerId "cust_error" → TransientWorkerException (simulate DB issue) Same
- * sagaId twice → idempotency returns existing orderId
- */
 @Slf4j
 @Service
 @RequiredArgsConstructor