Skip to content

Commit

Permalink
Fix for BUG: failing test_hierharchy_arraylist with jdk>=21 (#741)
Browse files Browse the repository at this point in the history
* test JDK releases

* less JDKs for now

* make testcase pass?

* no java 20 or newer for temurin on Windows

* more explicit exclusions

* lets test from 8 to 23
  • Loading branch information
cmacdonald authored Feb 6, 2025
1 parent f91a3c2 commit ebef177
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
13 changes: 11 additions & 2 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
java:
- '8'
- '11'
- '20'
- '23'
os:
# macos-latest (ATM macos-14) runs on Apple Silicon,
# macos-13 runs on Intel
Expand Down Expand Up @@ -59,7 +59,16 @@ jobs:
- os: windows-latest
architecture: x86
java: '20'

- os: windows-latest
architecture: x86
java: '21'
- os: windows-latest
architecture: x86
java: '22'
- os: windows-latest
architecture: x86
java: '23'

runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@master
Expand Down
2 changes: 1 addition & 1 deletion tests/test_reflect.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def test_hierharchy_arraylist(self):
self.assertContains(d, "java.lang.Iterable")# interface
self.assertContains(d, "java.lang.Object")# root
maxLevel = max(d.values())
self.assertEqual(d["java.lang.Object"], maxLevel)
self.assertTrue(d["java.lang.Object"] in [maxLevel, maxLevel -1]) # Object should be pretty high up the hierarchy.
self.assertEqual(d["java.util.ArrayList"], 0)

def test_class(self):
Expand Down

0 comments on commit ebef177

Please sign in to comment.