Avoid some DRY issues + minor fixes + version bump

Author: misl6

pythonforandroid/bootstrap.py

@@ -14,6 +14,8 @@
     rmdir, move)
 from pythonforandroid.recipe import Recipe
 
+SDL_BOOTSTRAPS = ("sdl2", "sdl3")
+
 
 def copy_files(src_root, dest_root, override=True, symlink=False):
     for root, dirnames, filenames in walk(src_root):
@@ -150,7 +152,7 @@ def get_bootstrap_dirs(self):
         return bootstrap_dirs
 
     def _copy_in_final_files(self):
-        if self.name in ["sdl2", "sdl3"]:
+        if self.name in SDL_BOOTSTRAPS:
             # Get the paths for copying SDL's java source code:
             sdl_recipe = Recipe.get_recipe(self.name, self.ctx)
             sdl_build_dir = sdl_recipe.get_jni_dir()
@@ -193,7 +195,7 @@ def assemble_distribution(self):
     @classmethod
     def all_bootstraps(cls):
         '''Find all the available bootstraps and return them.'''
-        forbidden_dirs = ('__pycache__', 'common')
+        forbidden_dirs = ('__pycache__', 'common', '_sdl_common')
         bootstraps_dir = join(dirname(__file__), 'bootstraps')
         result = set()
         for name in listdir(bootstraps_dir):

pythonforandroid/bootstraps/_sdl_common/__init__.py

@@ -0,0 +1,49 @@
+from os.path import join
+
+import sh
+
+from pythonforandroid.toolchain import (
+    Bootstrap, shprint, current_directory, info, info_main)
+from pythonforandroid.util import ensure_dir, rmdir
+
+
+class SDLGradleBootstrap(Bootstrap):
+    name = "_sdl_common"
+
+    recipe_depends = []
+
+    def assemble_distribution(self):
+        info_main("# Creating Android project ({})".format(self.name))
+
+        rmdir(self.dist_dir)
+        info("Copying SDL/gradle build")
+        shprint(sh.cp, "-r", self.build_dir, self.dist_dir)
+
+        # either the build use environment variable (ANDROID_HOME)
+        # or the local.properties if exists
+        with current_directory(self.dist_dir):
+            with open('local.properties', 'w') as fileh:
+                fileh.write('sdk.dir={}'.format(self.ctx.sdk_dir))
+
+        with current_directory(self.dist_dir):
+            info("Copying Python distribution")
+
+            self.distribute_javaclasses(self.ctx.javaclass_dir,
+                                        dest_dir=join("src", "main", "java"))
+
+            for arch in self.ctx.archs:
+                python_bundle_dir = join(f'_python_bundle__{arch.arch}', '_python_bundle')
+                ensure_dir(python_bundle_dir)
+
+                self.distribute_libs(arch, [self.ctx.get_libs_dir(arch.arch)])
+                site_packages_dir = self.ctx.python_recipe.create_python_bundle(
+                    join(self.dist_dir, python_bundle_dir), arch)
+                if not self.ctx.with_debug_symbols:
+                    self.strip_libraries(arch)
+                self.fry_eggs(site_packages_dir)
+
+            if 'sqlite3' not in self.ctx.recipe_build_order:
+                with open('blacklist.txt', 'a') as fileh:
+                    fileh.write('\nsqlite3/*\nlib-dynload/_sqlite3.so\n')
+
+        super().assemble_distribution()

pythonforandroid/bootstraps/sdl2/build/.gitignore renamed to pythonforandroid/bootstraps/_sdl_common/build/.gitignore

@@ -0,0 +1,22 @@
+LOCAL_PATH := $(call my-dir)
+
+include $(CLEAR_VARS)
+
+LOCAL_MODULE := main
+
+SDL_PATH := ../../SDL
+
+LOCAL_C_INCLUDES := $(LOCAL_PATH)/$(SDL_PATH)/include
+
+# Add your application source files here...
+LOCAL_SRC_FILES := start.c
+
+LOCAL_CFLAGS += -I$(PYTHON_INCLUDE_ROOT) $(EXTRA_CFLAGS)
+
+LOCAL_SHARED_LIBRARIES := SDL3 python_shared
+
+LOCAL_LDLIBS := -lGLESv1_CM -lGLESv2 -llog $(EXTRA_LDLIBS)
+
+LOCAL_LDFLAGS += -L$(PYTHON_LINK_ROOT) $(APPLICATION_ADDITIONAL_LDFLAGS)
+
+include $(BUILD_SHARED_LIBRARY)

pythonforandroid/bootstraps/sdl2/build/blacklist.txt renamed to pythonforandroid/bootstraps/_sdl_common/build/blacklist.txt

@@ -0,0 +1,13 @@
+LOCAL_PATH := $(call my-dir)
+
+include $(CLEAR_VARS)
+
+LOCAL_MODULE := main
+
+LOCAL_SRC_FILES := start.c
+
+LOCAL_STATIC_LIBRARIES := SDL3_static
+
+
+include $(BUILD_SHARED_LIBRARY)
+$(call import-module,SDL)LOCAL_PATH := $(call my-dir)

pythonforandroid/bootstraps/sdl2/build/jni/Application.mk renamed to pythonforandroid/bootstraps/_sdl_common/build/jni/Application.mk

@@ -0,0 +1,5 @@
+
+#define BOOTSTRAP_NAME_SDL3
+
+const char bootstrap_name[] = "SDL3";  // capitalized for historic reasons
+