Refactor calling .login() outside of __init__() method of Xmlrpc classes

and call .login() as part of TCMS.__init__() instead!

`__init__` method calls overridden method :

Call to self.login in __init__ method, which is overridden by method
TCMSKerbXmlrpc.login.

When an instance of a class is initialized, the super-class state should
be fully initialized before it becomes visible to the subclass. Calling
methods of the subclass in the superclass' __init__ method violates this
important invariant.

Author: atodorov

tcms_api/__init__.py

@@ -112,22 +112,26 @@ def __init__(self):
         config = ConfigParser()
         config.read(self._path)
 
+        rpc_implementor = None
+        server_url = self.server_url(config)
         if strtobool(config["tcms"].get("use_kerberos", "False")):
             # use Kerberos
-            TCMS._connection = TCMSKerbXmlrpc(
-                None, None, self.server_url(config)
-            ).server
-            return
-
-        try:
-            # use password authentication
-            TCMS._connection = TCMSXmlrpc(
-                config["tcms"]["username"],
-                config["tcms"]["password"],
-                self.server_url(config),
-            ).server
-        except KeyError as err:
-            raise RuntimeError(f"username/password required in {self._path}") from err
+            rpc_implementor = TCMSKerbXmlrpc(None, None, server_url)
+        else:
+            try:
+                # use password authentication
+                rpc_implementor = TCMSXmlrpc(
+                    config["tcms"]["username"],
+                    config["tcms"]["password"],
+                    server_url,
+                )
+            except KeyError as err:
+                raise RuntimeError(
+                    f"username/password required in {self._path}"
+                ) from err
+
+        rpc_implementor.login()
+        TCMS._connection = rpc_implementor.server
 
         return
 

tcms_api/xmlrpc.py

@@ -116,13 +116,15 @@ def __init__(self, username, password, url):
             url, transport=self.transport, verbose=VERBOSE, allow_none=1
         )
 
-        self.login(username, password, url)
+        self.username = username
+        self.password = password
+        self.url = url
 
-    def login(self, username, password, url):  # pylint: disable=unused-argument
+    def login(self):
         """
         Login in the web app to save a session cookie in the cookie jar!
         """
-        self.server.Auth.login(username, password)
+        self.server.Auth.login(self.username, self.password)
 
 
 class TCMSKerbXmlrpc(TCMSXmlrpc):
@@ -146,8 +148,8 @@ def __init__(self, username, password, url):
 
         super().__init__(username, password, url)
 
-    def login(self, username, password, url):
-        url = url.replace("xml-rpc", "login/kerberos")
+    def login(self):
+        url = self.url.replace("xml-rpc", "login/kerberos")
         hostname = get_hostname(url)
 
         _, headers, _ = self.transport.get_host_info(hostname)