Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify adding from collection & reorder mod/map priority #16

Open
laredson opened this issue Jun 13, 2023 · 9 comments
Open

feat: simplify adding from collection & reorder mod/map priority #16

laredson opened this issue Jun 13, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@laredson
Copy link

Describe the bug
While installing mods from list, it has moved forward a step... now doesn't ask to choose a module if the mod has only one modID, but still asks where in the priority list should be placed.
As this game has little to no requirements in mod priority, this seems more of a bug or unintended functioning

To Reproduce
Try to install from a collection

Expected behavior
Never ask where to place mod priority, only if the mod has several modules inside.

Desktop (please complete the following information):

  • OS: Windows
  • Version 2.0.1

Additional context
Also it should install all maps to the start of the list without asking. there's only a few mods that need to me placed at the very start of the list before every other mod, and those are RV interior, basements and such mods adding further "minihouses" for use in vehicles. If we are installing it we'll know those should be up. Anyways, they should work even it not placed on top, just before muldraug that should be always the last

@kldzj
Copy link
Owner

kldzj commented Jun 13, 2023

Never ask where to place mod priority, only if the mod has several modules inside.

There are mods that need to (or at least ask to) be placed in the very beginning, same goes for the maps.

I might just add toggles when starting to add from a collection that would allow this behavior.

@laredson
Copy link
Author

Which ones are those? Never found any mod that needs to be placed before. Even those mods requiring a secondary mod to function... the game just loads everything.
Only case I can think of is the patch I made for lifestyle mod, named lifestyle meditation feeds. As it overwrites two files inside the original mod. Anyways, it is placed second on the just even if autosort by alphabetical order

@kldzj
Copy link
Owner

kldzj commented Jun 13, 2023

I can't recite any specific mods right now, but I remember there being a few mods that I used that required early loading.

Not sure how to feel about changing the default behavior further, but I'll be adding toggles for this.

@laredson
Copy link
Author

I might just add toggles when starting to add from a collection that would allow this behavior.

I think it would work something like that, but default to autoplace down for mods, up for maps.
Now you mention it, yes... I miss an option to reorder ModID and map. What about just don't add a toggle, but add a reorder function to change those few mods that would need certain places

@kldzj
Copy link
Owner

kldzj commented Jun 13, 2023

Now you mention it, yes... I miss an option to reorder ModID and map. What about just don't add a toggle, but add a reorder function to change those few mods that would need certain places

Current flow for that would be to remove and then add again, but I definitely see the benefit of this.

@laredson
Copy link
Author

I can't recite any specific mods right now, but I remember there being a few mods that I used that required early loading.

yeah you're right, even if there weren't any atm, in some moment it would appear something that's be needing to be placed somewhere to work.
My point is that there are so little mods that would need that, and even those that explicitly say where to put, in the end they result in be working even if not placed. Somehow PZ manages to load all mods, I think it loads them twice or three times if it detect an error while loading server.

@kldzj
Copy link
Owner

kldzj commented Jun 13, 2023

Yeah, I quite like your proposal. It'd make adding mods, especially from collections much easier.

Related/closes #6

@kldzj kldzj self-assigned this Jun 13, 2023
@kldzj kldzj added the enhancement New feature or request label Jun 13, 2023
@kldzj kldzj changed the title bug: still asking to position mod feat: simplify adding from collection & reorder mod/map priority Jun 13, 2023
@laredson
Copy link
Author

Current flow for that would be to remove and then add again, but I definitely see the benefit of this.

mmm I imagine a mod list, as in remove mods, but when you select one it's almost the same as installing it again, as install a mod is adding workshopID and modID... a "reinstall" option would be enough so the program let you choose it's place again

@laredson
Copy link
Author

there's only a few mods that need to me placed at the very start of the list before every other mod, and those are RV interior, basements and such mods

I'm think out of the box while saying this, but...
As there's only a few mods to be placed up in maps, maybe you're able to just mark those mods? Not by the API ofc.. but a small db adding those mods that ask to be placed in their description. I would provide all ID that I would find to be needed of placing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants