Skip to content

Commit d7b7b9e

Browse files
authored
Use mergepatch for PDB (#584)
Signed-off-by: Tamal Saha <[email protected]>
1 parent b23cf43 commit d7b7b9e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

policy/v1/pdb.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ package v1
1919
import (
2020
"context"
2121

22+
jsonpatch "github.com/evanphx/json-patch"
2223
"github.com/pkg/errors"
2324
policy "k8s.io/api/policy/v1"
2425
kerr "k8s.io/apimachinery/pkg/api/errors"
2526
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2627
"k8s.io/apimachinery/pkg/types"
27-
"k8s.io/apimachinery/pkg/util/strategicpatch"
2828
"k8s.io/apimachinery/pkg/util/wait"
2929
"k8s.io/client-go/kubernetes"
3030
"k8s.io/klog/v2"
@@ -67,15 +67,15 @@ func PatchPodDisruptionBudgetObject(ctx context.Context, c kubernetes.Interface,
6767
return nil, kutil.VerbUnchanged, err
6868
}
6969

70-
patch, err := strategicpatch.CreateTwoWayMergePatch(curJson, modJson, policy.PodDisruptionBudget{})
70+
patch, err := jsonpatch.CreateMergePatch(curJson, modJson)
7171
if err != nil {
7272
return nil, kutil.VerbUnchanged, err
7373
}
7474
if len(patch) == 0 || string(patch) == "{}" {
7575
return cur, kutil.VerbUnchanged, nil
7676
}
7777
klog.V(3).Infof("Patching PodDisruptionBudget %s with %s.", cur.Name, string(patch))
78-
out, err := c.PolicyV1().PodDisruptionBudgets(cur.Namespace).Patch(ctx, cur.Name, types.StrategicMergePatchType, patch, opts)
78+
out, err := c.PolicyV1().PodDisruptionBudgets(cur.Namespace).Patch(ctx, cur.Name, types.MergePatchType, patch, opts)
7979
return out, kutil.VerbPatched, err
8080
}
8181

0 commit comments

Comments
 (0)