Wait for loadbalancer to be "ready" before testing (#333)

* Wait for loadbalancer to be "ready" before testing

* Include library for wait_until_service_has_external_http_address

* Can't make the function wait until things are working, move the wait into main

Author: Evan Anderson

test/e2e-library-deployments.sh

@@ -45,6 +45,8 @@ function deploy_contour() {
   echo ">> Waiting for Contour operator deployment to be available"
   kubectl wait deploy --for=condition=Available --timeout=120s -n "contour-operator" -l '!job-name'
 
+  # TODO: kind-ify this to support both LB and NodePort like Istio
+
   ko resolve -f ./third_party/contour/gateway/ | \
       sed 's/LoadBalancerService/NodePortService/g' | \
       kubectl apply -f -

test/e2e-tests.sh

@@ -28,6 +28,11 @@ initialize "$@" --skip-istio-addon
 
 deploy_gateway_for istio
 
+# When running in a "real" cluster, we need to wait for the loadbalancer IP to
+# be assigned before running e2e tests. Due to import dependencies, we can't
+# run this in deploy_gateway_for.
+wait_until_service_has_external_http_address istio-system istio-ingressgateway
+
 # Run the tests
 header "Running e2e tests with all available Gateway API vendors installed"
 e2e_istio