Skip to content

Commit 215d97f

Browse files
committed
Fix MultiOutputListener @parameters not being marked resolved
Signed-off-by: Squareys <[email protected]>
1 parent b3c4f7a commit 215d97f

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

org.knime.scijava.commands/src/org/knime/scijava/commands/dialog/DefaultDialogService.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import javax.swing.JPanel;
66

77
import org.knime.core.util.Pair;
8-
import org.knime.scijava.commands.MultiOutputListener;
98
import org.knime.scijava.commands.widget.SettingsModelWidgetModel;
109
import org.scijava.module.Module;
1110
import org.scijava.module.ModuleException;
@@ -46,15 +45,6 @@ public Pair<JPanel, List<SettingsModelWidgetModel>> dialogPanel(
4645
public void buildPanel(final InputPanel<JPanel, JPanel> inputPanel,
4746
final Module module) throws ModuleException {
4847

49-
// automatically resolve special fields
50-
// FIXME can be extended using plugin mechanism?
51-
for (final ModuleItem<?> item : module.getInfo().inputs()) {
52-
if (MultiOutputListener.class
53-
.isAssignableFrom(item.getType())) {
54-
module.setResolved(item.getName(), true);
55-
}
56-
}
57-
5848
// build input panel
5949
super.buildPanel(inputPanel, module);
6050

org.knime.scijava.commands/src/org/knime/scijava/commands/module/DefaultNodeModule.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,10 @@ public DefaultNodeModule(final Context context, final ModuleInfo info,
9090
outputListener = new NodeModuleOutputChangedListener();
9191
for (final ModuleItem<?> item : info.inputs()) {
9292
if (MultiOutputListener.class.isAssignableFrom(item.getType())) {
93+
final String name = item.getName();
94+
9395
module.setInput(name, outputListener);
96+
module.resolveInput(name);
9497
outputListener.enableManualPush(true);
9598
}
9699
}

0 commit comments

Comments
 (0)