Skip to content

Commit 8d9bfd4

Browse files
committed
Avoid null checking getWidgetStyle()
Signed-off-by: Squareys <[email protected]>
1 parent 76acbea commit 8d9bfd4

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

org.knime.scijava.commands/src/org/knime/scijava/commands/settings/DefaultSettingsModelTypeService.java

+1-6
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,9 @@ public SettingsModelType getSettingsModelTypeFor(
5656

5757
@Override
5858
public SettingsModelType getSettingsModelTypeFor(final ModuleItem<?> item) {
59-
60-
// FIXME why do I need this check in case of scripts?... Why should you
61-
// not?
62-
if (item.getWidgetStyle() != null
63-
&& item.getWidgetStyle().equals(StyleHook.COLUMNSELECTION)) {
59+
if (StyleHook.COLUMNSELECTION.equals(item.getWidgetStyle())) {
6460
return new SettingsModelColumnSelectionType();
6561
} else {
66-
6762
// check cache
6863
final SettingsModelType plugin = m_pluginsByValue
6964
.get(item.getType());

0 commit comments

Comments
 (0)