Remove compilation from the settings validation

gab1one · gab1one · commit 6b5eac3868da · 2016-06-20T11:33:41.000+02:00
This is no longer needed as the code is compiled when the user switches
to the generated dialog. The compilation leads to an NullPointer
exception when copying script nodes though.
diff --git a/org.knime.scijava.scripting.node/src/org/knime/scijava/scripting/nodes/interactive/SciJavaScriptingNodeModel.java b/org.knime.scijava.scripting.node/src/org/knime/scijava/scripting/nodes/interactive/SciJavaScriptingNodeModel.java
@@ -282,8 +282,6 @@ protected void saveInternals(final File nodeInternDir,
     protected void validateSettings(final NodeSettingsRO settings)
             throws InvalidSettingsException {
         m_settings.validateSettings(settings, m_nodeModelSettingsService);
-        m_compileProduct = recompile(m_compiler, m_settings.getScriptCode(),
-                getCurrentLanguage(), m_errorWriter);
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -282,8 +282,6 @@ protected void saveInternals(final File nodeInternDir,`
`282`	`282`	`protected void validateSettings(final NodeSettingsRO settings)`
`283`	`283`	`throws InvalidSettingsException {`
`284`	`284`	`m_settings.validateSettings(settings, m_nodeModelSettingsService);`
`285`		`- m_compileProduct = recompile(m_compiler, m_settings.getScriptCode(),`
`286`		`- getCurrentLanguage(), m_errorWriter);`
`287`	`285`	`}`
`288`	`286`
`289`	`287`	`@Override`