🐛 Commentつきのtsconfig.jsonに対応 (#6)

Author: yoshiko-pg

package.json

@@ -1,12 +1,12 @@
 {
   "name": "eslint-plugin-strict-dependencies",
   "description": "ESlint plugin to define custom module dependency rules.",
-  "version": "0.0.2",
+  "version": "1.0.0",
   "repository": {
     "type": "git",
     "url": "https://github.com/knowledge-work/eslint-plugin-strict-dependencies.git"
   },
-    "keywords": [
+  "keywords": [
     "eslint",
     "eslintplugin",
     "lint",
@@ -27,7 +27,8 @@
   "devDependencies": {
     "is-glob": "^4.0.3",
     "jest": "^27.2.4",
-    "micromatch": "^4.0.4"
+    "micromatch": "^4.0.4",
+    "require-strip-json-comments": "^2.0.0"
   },
   "scripts": {
     "test": "jest --coverage"

strict-dependencies/resolveImportPath.js

@@ -1,7 +1,7 @@
 /* eslint-disable */
 
-const fs = require('fs')
 const path = require('path')
+const parseJSON = require('require-strip-json-comments')
 
 /**
  * import文のrootからのパスを求める
@@ -13,9 +13,9 @@ module.exports = (importPath, relativeFilePath) => {
   // Load tsconfig option
   // MEMO: tscとか使って簡単に読める方法がありそう
   try {
-    const tsConfigFile = fs.readFileSync(path.join(process.cwd(), '/tsconfig.json'), 'utf-8')
+    const tsConfigFilePath = path.join(process.cwd(), '/tsconfig.json')
     // Exists ts config
-    const tsConfig = JSON.parse(tsConfigFile)
+    const tsConfig = parseJSON(tsConfigFilePath)
     if (tsConfig.compilerOptions && tsConfig.compilerOptions.paths) {
       Object.keys(tsConfig.compilerOptions.paths).forEach((key) => {
         // FIXME: このlint ruleではimport先が存在するかチェックしておらず、複数のパスから正しい方を選択できないため[0]固定

yarn.lock

@@ -2098,6 +2098,13 @@ require-directory@^2.1.1:
   resolved "https://registry.yarnpkg.com/require-directory/-/require-directory-2.1.1.tgz#8c64ad5fd30dab1c976e2344ffe7f792a6a6df42"
   integrity sha1-jGStX9MNqxyXbiNE/+f3kqam30I=
 
+require-strip-json-comments@^2.0.0:
+  version "2.0.0"
+  resolved "https://registry.yarnpkg.com/require-strip-json-comments/-/require-strip-json-comments-2.0.0.tgz#71733597bdd5c8581e1c01af485e3540ddc1f5a4"
+  integrity sha512-Pta3KVBaVZ9DHMoOGRd+3PEc/EFZAQ1JVHQpKZfPo018fdT9iEsyPBzqNAgJAzKMF4kbr5G7GaqP0+UOwnGfPw==
+  dependencies:
+    strip-json-comments "^3.0"
+
 resolve-cwd@^3.0.0:
   version "3.0.0"
   resolved "https://registry.yarnpkg.com/resolve-cwd/-/resolve-cwd-3.0.0.tgz#0f0075f1bb2544766cf73ba6a6e2adfebcb13f2d"
@@ -2250,6 +2257,11 @@ strip-final-newline@^2.0.0:
   resolved "https://registry.yarnpkg.com/strip-final-newline/-/strip-final-newline-2.0.0.tgz#89b852fb2fcbe936f6f4b3187afb0a12c1ab58ad"
   integrity sha512-BrpvfNAE3dcvq7ll3xVumzjKjZQ5tI1sEUIKr3Uoks0XUl45St3FlatVqef9prk4jRDzhW6WZg+3bk93y6pLjA==
 
+strip-json-comments@^3.0:
+  version "3.1.1"
+  resolved "https://registry.yarnpkg.com/strip-json-comments/-/strip-json-comments-3.1.1.tgz#31f1281b3832630434831c310c01cccda8cbe006"
+  integrity sha512-6fPc+R4ihwqP6N/aIv2f1gMH8lOVtWQHoqC4yK6oSDVVocumAsfCqjkXnqiYMhmMwS/mEHLp7Vehlt3ql6lEig==
+
 supports-color@^5.3.0:
   version "5.5.0"
   resolved "https://registry.yarnpkg.com/supports-color/-/supports-color-5.5.0.tgz#e2e69a44ac8772f78a1ec0b35b689df6530efc8f"