Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running on emulator - custom URL is ignored #91

Open
abiemann opened this issue Jul 31, 2017 · 1 comment
Open

Running on emulator - custom URL is ignored #91

abiemann opened this issue Jul 31, 2017 · 1 comment

Comments

@abiemann
Copy link

abiemann commented Jul 31, 2017 •
edited
Loading

you can see on line 239 that the custom URL is ignored when there is an exception.
On the emulator there is an exception because the play store is not installed.
@abiemann abiemann changed the title showRateDialog() ignores custom URL Running on emulator - custom URL is ignored Jul 31, 2017
@abiemann
Copy link
Author

abiemann commented Jul 31, 2017 •
edited
Loading

the point is that in my project, I adjust the app name depending on the build flavor (staging or development) and just grabbing the package name is not desired behavior.

What I'll do is test if the play store is installed (it's possible to get it installed on some emulator images), if it's not I won't let the app show the RateThisApp dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abiemann