fix: handle case sensitivity for "Settings" sheet name with explicit error TASK-1353 (#5417)

### 📣 Summary
Improved error handling for case-sensitive "Settings" sheet names.


### 📖 Description
This update addresses an issue where a sheet named "Settings" with
uppercase or mixed case letters causes unexpected behavior. An explicit
error message is now raised to alert users of the case sensitivity,
ensuring they can resolve the issue easily.

Author: noliveleger

kpi/mixins/xls_exportable.py

@@ -14,9 +14,7 @@
 
 
 class XlsExportableMixin:
-    def ordered_xlsform_content(self,
-                                kobo_specific_types=False,
-                                append=None):
+    def ordered_xlsform_content(self, kobo_specific_types=False, append=None):
         # currently, this method depends on "FormpackXLSFormUtilsMixin"
         content = copy.deepcopy(self.content)
         if append:

kpi/serializers/v2/deployment.py

@@ -1,7 +1,7 @@
-# coding: utf-8
 from django.conf import settings
 from pyxform.errors import PyXFormError
 from rest_framework import serializers
+from xlsxwriter.exceptions import DuplicateWorksheetName
 
 from .asset import AssetSerializer
 
@@ -16,8 +16,9 @@ class DeploymentSerializer(serializers.Serializer):
     def _raise_unless_current_version(asset, validated_data):
         # Stop if the requester attempts to deploy any version of the asset
         # except the current one
-        if 'version_id' in validated_data and \
-                validated_data['version_id'] != str(asset.version_id):
+        if 'version_id' in validated_data and validated_data[
+            'version_id'
+        ] != str(asset.version_id):
             raise NotImplementedError(
                 'Only the current version_id can be deployed')
 
@@ -35,8 +36,8 @@ def create(self, validated_data):
         # 'deployed' boolean value
         try:
             asset.deploy(backend=backend_id, active=validated_data.get('active', False))
-        except PyXFormError as e:
-            raise serializers.ValidationError({'error': (f'ODK Validation Error: {e}')})
+        except (DuplicateWorksheetName, PyXFormError) as e:
+            raise serializers.ValidationError({'error': str(e)})
         return asset.deployment
 
     def update(self, instance, validated_data):

kpi/tests/api/v2/test_api_assets.py

@@ -1862,10 +1862,48 @@ def test_asset_deployment_validation_error(self):
         self.assertEqual(deploy_response.status_code, status.HTTP_400_BAD_REQUEST)
         self.assertEqual(
             deploy_response.data['error'],
-            (
-                'ODK Validation Error: '
-                "The survey element named 'Enter_an_int_number' has no label or hint."
-            ),
+            "The survey element named 'Enter_an_int_number' has no label or hint.",
+        )
+
+    def test_asset_deployment_with_sheet_name_Settings(self):  # noqa
+        content = {
+            'schema': '1',
+            'survey': [
+                {
+                    'name': 'Enter_a_float_number',
+                    'type': 'decimal',
+                    'label': ['Enter a float number'],
+                    'required': False,
+                },
+            ],
+            'choices': [],
+            'settings': {},
+            'Settings': [],  # simulate sheet name called `Settings` on import
+        }
+        assets_url = reverse(self._get_endpoint('asset-list'))
+        asset_response = self.client.post(
+            assets_url,
+            {'content': content, 'asset_type': 'survey'},
+            format='json',
+        )
+        asset = Asset.objects.get(uid=asset_response.data.get('uid'))
+
+        deployment_url = reverse(
+            self._get_endpoint('asset-deployment'), kwargs={'uid': asset.uid}
+        )
+
+        deploy_response = self.client.post(
+            deployment_url,
+            {
+                'backend': 'mock',
+                'active': True,
+            },
+        )
+
+        assert deploy_response.status_code == status.HTTP_400_BAD_REQUEST
+        assert (
+            "Sheetname 'Settings', with case ignored, is already in use"
+            in deploy_response.data['error']
         )
 
     @patch('kpi.views.v2.asset.ProjectHistoryLog.create_from_deployment_request')