Fix preference clearing

kohler · Sep 14, 2024 · f9afc92 · f9afc92
1 parent f23b555
commit f9afc92
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/assigners/a_preference.php b/src/assigners/a_preference.php
@@ -174,7 +174,7 @@ function unparse_description() {
     }
     /** @return PaperReviewPreference */
     private function preference_data($before) {
-        $pref = $this->item->get($before, "_pref");
+        $pref = $this->item->get($before, "_pref") ?? 0;
         $exp = $this->item->get($before, "_exp");
         if ($exp === "N") {
             $exp = null;

diff --git a/src/paperinfo.php b/src/paperinfo.php
@@ -13,7 +13,7 @@ class PaperReviewPreference {
     /** @param int $preference
      * @param ?int $expertise */
     function __construct($preference = 0, $expertise = null) {
-        $this->preference = $preference;
+        $this->preference = $preference ?? 0;
         $this->expertise = $expertise;
     }
 
@@ -29,7 +29,7 @@ function exists() {
 
     /** @return string */
     function unparse() {
-        return ($this->preference ?? "0") . unparse_expertise($this->expertise);
+        return $this->preference . unparse_expertise($this->expertise);
     }
 
     /** @param PaperReviewPreference $a