Skip to content

Commit db2f8e6

Browse files
authored
Fix typos and enable links (#109)
* chore: enable youtube link * chore: correct typos in comments
1 parent 2c5e9e6 commit db2f8e6

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

BENCHMARK.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,5 +129,5 @@ small_vgicp : APE=5.956 +- 2.725 RPE(100)=1.315 +- 0.762 RPE(400)=6.8
129129

130130
[Code](https://github.com/koide3/small_gicp/blob/pybench/src/benchmark/odometry_benchmark.py)
131131

132-
Processing speed comparison between small_gicp and Open3D ([youtube]((https://youtu.be/LNESzGXPr4c?feature=shared))).
132+
Processing speed comparison between small_gicp and Open3D ([youtube](https://youtu.be/LNESzGXPr4c?feature=shared)).
133133
[![small_comp](https://github.com/koide3/small_gicp/assets/31344317/7959edd6-f0e4-4318-b4c1-a3f8755c407f)](https://youtu.be/LNESzGXPr4c?feature=shared)

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ python3 src/example/basic_registration.py
431431

432432
## [Benchmark](BENCHMARK.md)
433433

434-
Processing speed comparison between small_gicp and Open3D ([youtube]((https://youtu.be/LNESzGXPr4c?feature=shared))).
434+
Processing speed comparison between small_gicp and Open3D ([youtube](https://youtu.be/LNESzGXPr4c?feature=shared)).
435435
[![small_comp](https://github.com/koide3/small_gicp/assets/31344317/7959edd6-f0e4-4318-b4c1-a3f8755c407f)](https://youtu.be/LNESzGXPr4c?feature=shared)
436436

437437
### Downsampling

include/small_gicp/registration/optimizer.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ struct LevenbergMarquardtOptimizer {
108108
// Solve with damping
109109
const Eigen::Matrix<double, 6, 1> delta = (H + lambda * Eigen::Matrix<double, 6, 6>::Identity()).ldlt().solve(-b);
110110

111-
// Validte new solution
111+
// Validate new solution
112112
const Eigen::Isometry3d new_T = result.T_target_source * se3_exp(delta);
113113
double new_e = reduction.error(target, source, new_T, factors);
114114
general_factor.update_error(target, source, new_T, &e);
@@ -150,7 +150,7 @@ struct LevenbergMarquardtOptimizer {
150150

151151
bool verbose; ///< If true, print debug messages
152152
int max_iterations; ///< Max number of optimization iterations
153-
int max_inner_iterations; ///< Max number of inner iterations (lambda-trial)
153+
int max_inner_iterations; ///< Max number of inner iterations (lambda-trial)
154154
double init_lambda; ///< Initial lambda (damping factor)
155155
double lambda_factor; ///< Lambda increase factor
156156
};

0 commit comments

Comments
 (0)