Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return scrutinee #646

Closed
wants to merge 1 commit into from
Closed

Fix return scrutinee #646

wants to merge 1 commit into from

Conversation

TimWhiting
Copy link
Collaborator

Fixes #644

@TimWhiting TimWhiting mentioned this pull request Dec 27, 2024
Closed
@TimWhiting TimWhiting added this to the Small Release milestone Dec 27, 2024
@daanx
Copy link
Member

daanx commented Jan 29, 2025

I think this is already fixed by commit 1e962be (for issue #643) ? I'll close it for now if that is ok but feel free to reopen if I missed something of course :-)

@daanx daanx closed this Jan 29, 2025
@TimWhiting
Copy link
Collaborator Author

Interesting, yes this seems to have been fixed by your commit.

This fixes it prior to a return ending up in a subexpression of the match scrutinee - though I'm not sure I understand how it fixes it.

Whereas this PR lifts the match scrutinee to a binder, and then matches on the binder. (And does it in the unreturn pass)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Small Release
Development

Successfully merging this pull request may close these issues.

internal error: Backend.C.FromCore.genFunDefSig: not a function
2 participants
@TimWhiting @daanx