Merge pull request #340 from krishnprakash/alert-autofix-7

krishnprakash · web-flow · commit bfafb804e4bf · 2025-03-11T14:53:47.000+05:30
Potential fix for code scanning alert no. 7: Missed opportunity to use Select
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Extractor/Context.cs b/csharp/extractor/Semmle.Extraction.CSharp/Extractor/Context.cs
@@ -496,9 +496,8 @@ internal IParameterSymbol GetPossiblyCachedParameterSymbol(IParameterSymbol para
                 return param;
             }
 
-            foreach (var sr in param.DeclaringSyntaxReferences)
+            foreach (var syntax in param.DeclaringSyntaxReferences.Select(sr => sr.GetSyntax()))
             {
-                var syntax = sr.GetSyntax();
                 if (lambdaParameterCache.TryGetValue(syntax, out var cached) &&
                     SymbolEqualityComparer.Default.Equals(param, cached))
                 {

Original file line number	Diff line number	Diff line change
`@@ -496,9 +496,8 @@ internal IParameterSymbol GetPossiblyCachedParameterSymbol(IParameterSymbol para`
`496`	`496`	`return param;`
`497`	`497`	`}`
`498`	`498`
`499`		`- foreach (var sr in param.DeclaringSyntaxReferences)`
	`499`	`+ foreach (var syntax in param.DeclaringSyntaxReferences.Select(sr => sr.GetSyntax()))`
`500`	`500`	`{`
`501`		`- var syntax = sr.GetSyntax();`
`502`	`501`	`if (lambdaParameterCache.TryGetValue(syntax, out var cached) &&`
`503`	`502`	`SymbolEqualityComparer.Default.Equals(param, cached))`
`504`	`503`	`{`