Merge pull request #343 from krishnprakash/alert-autofix-11

krishnprakash · web-flow · commit e876db105a2d · 2025-03-11T15:05:42.000+05:30
Potential fix for code scanning alert no. 11: Local scope variable shadows member
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/TypeMention.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/TypeMention.cs
@@ -22,9 +22,9 @@ private TypeMention(Context cx, TypeSyntax syntax, IEntity parent, Type type, Mi
             this.loc = loc;
         }
 
-        private TypeSyntax GetArrayElementType(TypeSyntax type)
+        private TypeSyntax GetArrayElementType(TypeSyntax typeSyntax)
         {
-            switch (type)
+            switch (typeSyntax)
             {
                 case ArrayTypeSyntax ats:
                     return GetArrayElementType(ats.ElementType);
@@ -37,7 +37,7 @@ private TypeSyntax GetArrayElementType(TypeSyntax type)
                 case PointerTypeSyntax pts:
                     return GetArrayElementType(pts.ElementType);
                 default:
-                    return type;
+                    return typeSyntax;
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -22,9 +22,9 @@ private TypeMention(Context cx, TypeSyntax syntax, IEntity parent, Type type, Mi`
`22`	`22`	`this.loc = loc;`
`23`	`23`	`}`
`24`	`24`
`25`		`- private TypeSyntax GetArrayElementType(TypeSyntax type)`
	`25`	`+ private TypeSyntax GetArrayElementType(TypeSyntax typeSyntax)`
`26`	`26`	`{`
`27`		`- switch (type)`
	`27`	`+ switch (typeSyntax)`
`28`	`28`	`{`
`29`	`29`	`case ArrayTypeSyntax ats:`
`30`	`30`	`return GetArrayElementType(ats.ElementType);`
`@@ -37,7 +37,7 @@ private TypeSyntax GetArrayElementType(TypeSyntax type)`
`37`	`37`	`case PointerTypeSyntax pts:`
`38`	`38`	`return GetArrayElementType(pts.ElementType);`
`39`	`39`	`default:`
`40`		`- return type;`
	`40`	`+ return typeSyntax;`
`41`	`41`	`}`
`42`	`42`	`}`
`43`	`43`