Dash Incompatible - Masternode payment missing.

[shtse8]

Logs:

2017-09-28 21:26:31 [Pool]	[dash] (Thread 5) Submitted Block using submitblock successfully to daemon instance(s)
2017-09-28 21:26:31 [Pool]	[dash] (Thread 5) Block found: 00000000000003b2cbefd821582beafc83aff4eb80303c44c4fd0b7019795267 by cmpool.nicehash
2017-09-28 21:26:31 [Pool]	[dash] (Thread 5) Share was found with diff higher than 1.000.000!
2017-09-28 21:26:31 [Pool]	[dash] (Thread 5) Share accepted at diff 2712.79414057/4536245.30421248 by cmpool.nicehash [::ffff:37.58.65.213]
2017-09-28 21:26:31 [MySQL]	[dash] Share inserted

It is the block created at that time.
https://chainz.cryptoid.info/dash/block.dws?744973.htm

You can see the diff is ~3M. So my hash is enough to mine a block.
But I can't see any successful block mined by me. But I found a block mined before mine 10s ago. Does it mean I am 10 seconds slower than others? So the daemon accepted my answer, but no block mined?

[shtse8]

One new block again.

2017-09-28 22:26:03 [Pool]	[dash] (Thread 3) Submitted Block using submitblock successfully to daemon instance(s)
2017-09-28 22:26:03 [Pool]	[dash] (Thread 3) Block found: 000000000000038efed2b80d297c38341c2a2c74fe9343b7f2e8fa8dc7888dd7 by cmpool.nicehash
2017-09-28 22:26:03 [Pool]	[dash] (Thread 3) Share was found with diff higher than 1.000.000!
2017-09-28 22:26:03 [Pool]	[dash] (Thread 3) Share accepted at diff 7046.80851064/4714515.29472467 by cmpool.nicehash [::ffff:198.11.220.46]
2017-09-28 22:26:03 [MySQL]	[dash] Share inserted

A block before that time:
https://chainz.cryptoid.info/dash/block.dws?744996.htm

Does it mean someone mined a block 30s before mes? So why my daemon still accept my hash?

[shtse8]

I lost one bitcoin and found the reason. It seems this stratum cannot support dash as it didn't handle masternode payment.

2017-09-28 22:26:03 CMasternodeBlockPayees::IsTransactionValid -- ERROR: Missing required payment, possible payees: 'Xw3ZVqwUuSBwZ2okk7NRqtEb9QZ3jkv6Dh', amount: 1.802743 DASH
2017-09-28 22:26:03 IsBlockPayeeValid -- ERROR: Invalid masternode payment detected at height 744997: CTransaction(hash=c66fa45062, ver=1, vin.size=1, vout.size=1, nLockTime=0)
    CTxIn(COutPoint(0000000000000000000000000000000000000000000000000000000000000000, 4294967295), coinbase 03255e0b04f176cd5908500000b37f3600000d2f6e6f64655374726174756d2f, nSequence=0)
    CTxOut(nValue=3.60548601, scriptPubKey=76a9148e26bfcfc0adb786d4d1649e)
2017-09-28 22:26:03 ERROR: ConnectBlock(DASH): couldn't find masternode or superblock payments
2017-09-28 22:26:03 InvalidChainFound: invalid block=000000000000038efed2b80d297c38341c2a2c74fe9343b7f2e8fa8dc7888dd7  height=744997  log2_work=67.99053  date=2017-09-28 22:25:53
2017-09-28 22:26:03 InvalidChainFound:  current best=00000000000002a3807858b7791f73dfccb05ea9e56dcbae1853be5ebfedc455  height=744996  log2_work=67.990445  date=2017-09-28 22:25:26
2017-09-28 22:26:03 ERROR: ConnectTip(): ConnectBlock 000000000000038efed2b80d297c38341c2a2c74fe9343b7f2e8fa8dc7888dd7 failed
2017-09-28 22:26:03 InvalidChainFound: invalid block=000000000000038efed2b80d297c38341c2a2c74fe9343b7f2e8fa8dc7888dd7  height=744997  log2_work=67.99053  date=2017-09-28 22:25:53
2017-09-28 22:26:03 InvalidChainFound:  current best=00000000000002a3807858b7791f73dfccb05ea9e56dcbae1853be5ebfedc455  height=744996  log2_work=67.990445  date=2017-09-28 22:25:26
2017-09-28 22:26:03 ProcessNewBlock : ACCEPTED

[shtse8]

zone117x/node-stratum-pool#123

[krisklosterman]

Need someone to test the pull request in node stratum pool please. Need to make sure it does not affect other algorithms in a negative way.

[shtse8]

I have tested Dash x11. It works fine now. It will try START x11 today later. But I prefer you should make a note in README.md to warn others for using the current version since the current readme says it supports DRK x11 (DASH x11). I am also setting up XMR and DGB. So let me test these two coins.