Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label CRDs with owning ResourceGroup information #185

Open
a-hilaly opened this issue Jan 9, 2025 · 2 comments
Open

label CRDs with owning ResourceGroup information #185

a-hilaly opened this issue Jan 9, 2025 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature

Comments

@a-hilaly
Copy link
Member

a-hilaly commented Jan 9, 2025

Feature Description

Currently when kro creates CRDs from ResourceGroups, these CRDs lack metadata about their origin. ideally we to automatically label CRDs with their owning ResourceGroup information. This allows kro to track which ResourceGroup owns which CRD, enabling better conflict detection and resource management.

We can leverage the metadata library that we already use for sub resources https://github.com/awslabs/kro/blob/main/pkg/metadata/labels.go

@a-hilaly a-hilaly added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 29, 2025
@gerardocorea
Copy link

Instead of labels should owner references be set on the child resources so should the parent resource be deleted the child ones will also be cleaned up? i wouldnt mind looking into this.

@Gonfidel
Copy link

Gonfidel commented Feb 8, 2025

I have created MR #282 in response to this issue. Please let me know if this meets the issues requirements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature
Projects
None yet
Development

No branches or pull requests

3 participants