Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

informer not shutting down properly when RG is deleted #189

Open
a-hilaly opened this issue Jan 9, 2025 · 0 comments
Open

informer not shutting down properly when RG is deleted #189

a-hilaly opened this issue Jan 9, 2025 · 0 comments
Labels
kind/bug Something isn't working

Comments

@a-hilaly
Copy link
Member

a-hilaly commented Jan 9, 2025

Description

When a ResourceGroup is deleted, the dynamiccontroller's informer for that RG's corresponding GVR isn't properly shutting down. After calling UnregisterGVK, the informer appears to still be running despite cleanup attempts. This could be an upstream Kubernetes client-go bug or an implementation issue in our shutdown logic.

Current behavior in dynamiccontroller.UnregisterGVK:

  • Calls wrapper.shutdown() to cancel context
  • Calls wrapper.informer.Shutdown()
  • Removes informer from maps/caches
  • Informer still appears active

Investigation steps needed:

  • Check if client-go's DynamicSharedInformerFactory Shutdown is working correctly
  • Verify our context cancellation propagation

Which option describes the most your issue?

No response

@a-hilaly a-hilaly added the kind/bug Something isn't working label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant